-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Perf Fix] Use Where clause on change event listing #15430
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 failed tests on run #33309 ↗︎Details:
|
Test | Artifacts | |
---|---|---|
Teams flow should work properly > Update description for created team |
Screenshots
Video
|
Pages/Tags.spec.js • 1 failed test • cypress-ci-mysql-pr-8141805652-1
Test | Artifacts | |
---|---|---|
Classification Page > Should render basic elements on page |
Screenshots
Video
|
Features/QueryEntity.spec.js • 1 failed test • cypress-ci-mysql-pr-8141805652-1
Test | Artifacts | |
---|---|---|
Query Entity > Update owner, description and tag |
Screenshots
Video
|
Pages/Policies.spec.js • 2 failed tests • cypress-ci-mysql-pr-8141805652-1
Test | Artifacts | |
---|---|---|
Policy page should work properly > Add new policy |
Screenshots
Video
|
|
Policy page should work properly > Edit policy description |
Screenshots
Video
|
The first 5 failed specs are shown, see all 9 specs in Cypress Cloud.
Review all test suite changes for PR #15430 ↗︎
- Ignore Query Entity for Change Event Update
|
pmbrull
approved these changes
Mar 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to add a partition to change_event by entityType as well?
mohityadav766
added a commit
that referenced
this pull request
Mar 4, 2024
* - Use Where clause on change event listing * - Poll in a minute * - Fix Entity Url - Ignore Query Entity for Change Event Update (cherry picked from commit 7e66756)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
I worked on ... because ...
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>