Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf Fix] Use Where clause on change event listing #15430

Merged
merged 4 commits into from
Mar 4, 2024
Merged

Conversation

mohityadav766
Copy link
Contributor

Describe your changes:

  • Use where before listing

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@mohityadav766 mohityadav766 self-assigned this Mar 2, 2024
@mohityadav766 mohityadav766 requested a review from a team as a code owner March 2, 2024 18:36
@github-actions github-actions bot added backend safe to test Add this label to run secure Github workflows on PRs labels Mar 2, 2024
Copy link

cypress bot commented Mar 2, 2024

14 failed tests on run #33309 ↗︎

14 709 12 0 Flakiness 0

Details:

- Fix Entity Url
Project: openmetadata Commit: e8cd24e4af
Status: Errored Duration: 15:34 💡
Started: Mar 4, 2024 2:44 PM Ended: Mar 4, 2024 4:00 PM
Failed  Service/ServiceIngestion.spec.ts • 3 failed tests • cypress-ci-mysql-pr-8141805652-1

View Output Video

Test Artifacts
Superset Ingestion > Create & Ingest Superset service Screenshots Video
Superset Ingestion > Update schedule options and verify Screenshots Video
Superset Ingestion > Delete Superset service Screenshots Video
Failed  Pages/Teams.spec.js • 1 failed test • cypress-ci-mysql-pr-8141805652-1

View Output Video

Test Artifacts
Teams flow should work properly > Update description for created team Screenshots Video
Failed  Pages/Tags.spec.js • 1 failed test • cypress-ci-mysql-pr-8141805652-1

View Output Video

Test Artifacts
Classification Page > Should render basic elements on page Screenshots Video
Failed  Features/QueryEntity.spec.js • 1 failed test • cypress-ci-mysql-pr-8141805652-1

View Output Video

Test Artifacts
Query Entity > Update owner, description and tag Screenshots Video
Failed  Pages/Policies.spec.js • 2 failed tests • cypress-ci-mysql-pr-8141805652-1

View Output Video

Test Artifacts
Policy page should work properly > Add new policy Screenshots Video
Policy page should work properly > Edit policy description Screenshots Video

The first 5 failed specs are shown, see all 9 specs in Cypress Cloud.

Review all test suite changes for PR #15430 ↗︎

- Ignore Query Entity for Change Event Update
Copy link

sonarqubecloud bot commented Mar 4, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Collaborator

@pmbrull pmbrull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add a partition to change_event by entityType as well?

@mohityadav766 mohityadav766 merged commit 7e66756 into main Mar 4, 2024
9 of 15 checks passed
@mohityadav766 mohityadav766 deleted the perf-fix branch March 4, 2024 17:18
mohityadav766 added a commit that referenced this pull request Mar 4, 2024
* - Use Where clause on change event listing

* - Poll in a minute

* - Fix Entity Url
- Ignore Query Entity for Change Event Update

(cherry picked from commit 7e66756)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants