Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: type errors for pr #15297 #15411

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Conversation

Sachin-chaurasiya
Copy link
Contributor

Describe your changes:

I worked on fixing the type error for pr #15297 changes.

Type of change:

  • Bug fix

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Sachin-chaurasiya Sachin-chaurasiya enabled auto-merge (squash) February 29, 2024 16:53
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 62%
62.59% (32060/51221) 40.61% (12529/30850) 41.66% (3933/9440)

Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

cypress bot commented Feb 29, 2024

3 failed tests on run #33283 ↗︎

3 294 1 0 Flakiness 0

Details:

fix: type errors for pr #15297
Project: openmetadata Commit: f584007a56
Status: Failed Duration: 33:08 💡
Started: Feb 29, 2024 5:00 PM Ended: Feb 29, 2024 5:33 PM
Failed  cypress/e2e/Service/ServiceIngestion.spec.ts • 3 failed tests • cypress-ci-mysql-pr-8099503177-1

View Output Video

Test Artifacts
Superset Ingestion > Create & Ingest Superset service Screenshots Video
Superset Ingestion > Update schedule options and verify Screenshots Video
Superset Ingestion > Delete Superset service Screenshots Video

Review all test suite changes for PR #15411 ↗︎

@Sachin-chaurasiya Sachin-chaurasiya merged commit b881a59 into main Feb 29, 2024
16 of 18 checks passed
@Sachin-chaurasiya Sachin-chaurasiya deleted the fix-type-error-for-pr-15297 branch February 29, 2024 18:44
karanh37 pushed a commit that referenced this pull request Apr 4, 2024
(cherry picked from commit b881a59)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e:Integration e2e:Settings safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants