Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#15403 Team filter on the Data Insights page doesn't work as expected #15410

Merged
merged 2 commits into from
Mar 1, 2024
Merged

#15403 Team filter on the Data Insights page doesn't work as expected #15410

merged 2 commits into from
Mar 1, 2024

Conversation

ShaileshParmar11
Copy link
Contributor

@ShaileshParmar11 ShaileshParmar11 commented Feb 29, 2024 •
edited by Sachin-chaurasiya
Loading

Describe your changes:

Fixes #15403

fixed team filter selection

Screen.Recording.2024-02-29.at.9.27.50.PM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added UI UI specific issues e2e:Observability safe to test Add this label to run secure Github workflows on PRs labels Feb 29, 2024
@ShaileshParmar11 ShaileshParmar11 self-assigned this Feb 29, 2024
@ShaileshParmar11 ShaileshParmar11 marked this pull request as ready for review February 29, 2024 15:59
@github-actions GitHub Actions
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 62%
 62.66% (32060/51167) 40.67% (12529/30809) 41.69% (3933/9435)

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@cypress Cypress
Copy link

cypress bot commented Feb 29, 2024

Passing run #33282 ↗︎

0 45 6 0 Flakiness 0

Details:

Merge branch 'main' into issue-15403
Project: openmetadata Commit: 3591ceeb00
Status: Passed Duration: 05:29 💡
Started: Feb 29, 2024 4:19 PM Ended: Feb 29, 2024 4:24 PM

Review all test suite changes for PR #15410 ↗︎

chirag-madlani
chirag-madlani reviewed Mar 1, 2024
View reviewed changes
Copy link
Collaborator

@chirag-madlani chirag-madlani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShaileshParmar11 Do we have the tests for the same?

@Sachin-chaurasiya Sachin-chaurasiya merged commit 9e224b7 into main Mar 1, 2024
19 checks passed
@Sachin-chaurasiya Sachin-chaurasiya deleted the issue-15403 branch March 1, 2024 06:27
Sachin-chaurasiya pushed a commit that referenced this pull request Mar 1, 2024
@ShaileshParmar11 @Sachin-chaurasiya
#15403 Team filter on the Data Insights page doesn't work as expected (…
d3ff0d9 
…#15410)

(cherry picked from commit 9e224b7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani left review comments

@karanh37 karanh37 karanh37 approved these changes

@harshach harshach Awaiting requested review from harshach

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya

Assignees

@ShaileshParmar11 ShaileshParmar11

Labels
e2e:Observability safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Team filter on the Data Insights page doesn't work as expected
4 participants
@ShaileshParmar11 @chirag-madlani @karanh37 @Sachin-chaurasiya