Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ui): reduce routes from specific to generic to reduce the code #15404

Merged
merged 15 commits into from
Mar 5, 2024
Merged

chore(ui): reduce routes from specific to generic to reduce the code #15404

merged 15 commits into from
Mar 5, 2024

Conversation

chirag-madlani
Copy link
Collaborator

Describe your changes:

Fixes:

  • Grab entityType from the URL to easily load the component based on the type
  • Remove hardcoded entityType Path which creates junks to code
  • Club multiple paths rendering same component to string array and pass it as route path propr

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added UI UI specific issues e2e:Integration e2e:Governance e2e:Observability e2e:DataAssets safe to test Add this label to run secure Github workflows on PRs and removed UI UI specific issues labels Feb 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 1, 2024 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 62%
 63.03% (32134/50981) 40.84% (12551/30735) 41.84% (3934/9402)

@chirag-madlani chirag-madlani marked this pull request as ready for review March 1, 2024 08:29
@cypress Cypress
Copy link

cypress bot commented Mar 1, 2024 •
edited
Loading

4 failed tests on run #33319 ↗︎

4 508 10 0 Flakiness 0

Details:

Merge branch 'main' into chore-routes
Project: openmetadata Commit: d175cea079
Status: Errored Duration: 52:56 💡
Started: Mar 5, 2024 7:45 AM Ended: Mar 5, 2024 8:37 AM
Failed  cypress/e2e/Service/ServiceIngestion.spec.ts • 3 failed tests • cypress-ci-mysql-pr-8152531013-1

View Output Video

Test Artifacts
Superset Ingestion > Create & Ingest Superset service Screenshots Video
Superset Ingestion > Update schedule options and verify Screenshots Video
Superset Ingestion > Delete Superset service Screenshots Video

Review all test suite changes for PR #15404 ↗︎

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 5, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.4% Duplication on New Code

See analysis details on SonarCloud

@chirag-madlani chirag-madlani merged commit bb03e59 into main Mar 5, 2024
10 of 15 checks passed
@chirag-madlani chirag-madlani deleted the chore-routes branch March 5, 2024 09:04
@chirag-madlani chirag-madlani mentioned this pull request Mar 5, 2024
Merged
chirag-madlani added a commit that referenced this pull request Mar 6, 2024
@chirag-madlani
chore(ui): reduce routes from specific to generic to reduce the code (#…
6979428 
…15404)

* chore(ui): reduce routes from specific to generic to reduce the code

* cleanup on authenticated app router

* fix tests

* fix path for table then other type

* fix cypress

* address comments

* fix routes issue

* fix path issue for versino pages

(cherry picked from commit bb03e59)
chirag-madlani added a commit that referenced this pull request Mar 6, 2024
@chirag-madlani
Cleanup entity details (#15461)
7490663 
* chore(ui): move entitydetails loading to

* improve version page

* minor improvement for version

* fix tests

* chore(ui): reduce routes from specific to generic to reduce the code (#15404)

* chore(ui): reduce routes from specific to generic to reduce the code

* cleanup on authenticated app router

* fix tests

* fix path for table then other type

* fix cypress

* address comments

* fix routes issue

* fix path issue for versino pages

(cherry picked from commit bb03e59)

* fix paths

* fix tests

* fix mock issue

* fix java lint

* fix task path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sachin-chaurasiya Sachin-chaurasiya Sachin-chaurasiya left review comments

@Ashish8689 Ashish8689 Ashish8689 left review comments

@karanh37 karanh37 karanh37 approved these changes

@harshach harshach Awaiting requested review from harshach

Assignees
No one assigned
Labels
e2e:Governance e2e:Integration e2e:Observability safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chirag-madlani @karanh37 @Sachin-chaurasiya @Ashish8689