Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(CI): Use the standard cypress GHA way with environments #15399

Merged
merged 1 commit into from
Feb 29, 2024
Merged

fix(CI): Use the standard cypress GHA way with environments #15399

merged 1 commit into from
Feb 29, 2024

Conversation

akash-jain-10
Copy link
Collaborator

Use the standard cypress GHA way with environments.

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added devops safe to test Add this label to run secure Github workflows on PRs labels Feb 29, 2024
@akash-jain-10 akash-jain-10 self-assigned this Feb 29, 2024
chirag-madlani
chirag-madlani approved these changes Feb 29, 2024
View reviewed changes
Copy link
Collaborator

@chirag-madlani chirag-madlani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @akash-jain-10 🚀

@akash-jain-10 akash-jain-10 merged commit b15cd4e into main Feb 29, 2024
11 checks passed
@akash-jain-10 akash-jain-10 deleted the fix/cypress-pr-runs-on-parallel-machine branch February 29, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@harshach harshach Awaiting requested review from harshach harshach is a code owner

@dhruvinmaniar123 dhruvinmaniar123 Awaiting requested review from dhruvinmaniar123

Assignees

@akash-jain-10 akash-jain-10

Labels
devops safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akash-jain-10 @chirag-madlani