Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User and applications suggestions for entities #15345

Merged
merged 20 commits into from
Mar 8, 2024
Merged

Conversation

karanh37
Copy link
Contributor

@karanh37 karanh37 commented Feb 26, 2024

Describe your changes:

Show table level and column level suggested descriptions created by User or Metapilot.
Accept All and Reject All actions pending. Refer open-metadata/openmetadata-collate#367

Screen.Recording.2024-03-05.at.8.47.02.PM.mov

image

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added UI UI specific issues e2e:DataAssets e2e:Settings safe to test Add this label to run secure Github workflows on PRs labels Feb 26, 2024
@karanh37 karanh37 changed the title Add Metapilot App Config Add General App Config for Pub Sub architecture Feb 26, 2024
Copy link
Contributor

github-actions bot commented Feb 26, 2024

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 63%
63.3% (32440/51247) 40.92% (12645/30902) 41.9% (3955/9440)

Copy link

cypress bot commented Feb 26, 2024

1 failed test on run #33365 ↗︎

1 445 12 0 Flakiness 0

Details:

fix unit tests
Project: openmetadata Commit: 89f87c1bf1
Status: Errored Duration: 37:51 💡
Started: Mar 8, 2024 8:46 AM Ended: Mar 8, 2024 9:24 AM

Review all test suite changes for PR open-metadata/OpenMetadata#15345 ↗︎

@karanh37 karanh37 marked this pull request as draft February 29, 2024 13:37
@karanh37 karanh37 changed the title Add General App Config for Pub Sub architecture User and applications suggestions for entities Mar 7, 2024
@karanh37 karanh37 marked this pull request as ready for review March 7, 2024 15:30
chirag-madlani
chirag-madlani previously approved these changes Mar 8, 2024
Copy link

sonarqubecloud bot commented Mar 8, 2024

@chirag-madlani chirag-madlani merged commit 14f280b into main Mar 8, 2024
14 of 16 checks passed
@chirag-madlani chirag-madlani deleted the metapilot-oss branch March 8, 2024 09:44
karanh37 added a commit that referenced this pull request Mar 20, 2024
* add metapilot app oss side config

* add metapilot app oss side config

* suggestions changes

* locales

* pushing progress

* localisation

* add suggestions count button

* locales

* fix tests

* add tests

* fix sonar issues

* fix tests and cleanup

* fix unit tests

(cherry picked from commit 14f280b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e:Observability e2e:Settings safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants