Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui): typescript support for cypress tests #15239

Merged
merged 19 commits into from
Mar 7, 2024
Merged

chore(ui): typescript support for cypress tests #15239

merged 19 commits into from
Mar 7, 2024

Conversation

chirag-madlani
Copy link
Collaborator

Move cypress tests to typescript for easy writing of tests

@github-actions github-actions bot added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs and removed e2e:Integration labels Feb 19, 2024
@chirag-madlani chirag-madlani marked this pull request as draft February 19, 2024 10:53
Copy link
Contributor

github-actions bot commented Feb 19, 2024

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 63%
63.3% (32267/50976) 40.88% (12570/30745) 41.95% (3937/9384)

Copy link

cypress bot commented Feb 26, 2024

5 failed tests on run #33353 ↗︎

5 520 11 0 Flakiness 0

Details:

Merge branch 'main' into cy-ts
Project: openmetadata Commit: 4a38710029
Status: Failed Duration: 55:14 💡
Started: Mar 7, 2024 5:20 AM Ended: Mar 7, 2024 6:16 AM
Failed  Service/ServiceIngestion.spec.ts • 3 failed tests • cypress-ci-mysql-pr-8183152240-1

View Output Video

Test Artifacts
Superset Ingestion > Create & Ingest Superset service Screenshots Video
Superset Ingestion > Update schedule options and verify Screenshots Video
Superset Ingestion > Delete Superset service Screenshots Video
Failed  Pages/Domains.spec.ts • 1 failed test • cypress-ci-mysql-pr-8183152240-1

View Output Video

Test Artifacts
Domain page should work properly > Remove Domain from entity should work properly Screenshots Video
Failed  Flow/Explore.spec.ts • 1 failed test • cypress-ci-mysql-pr-8183152240-1

View Output Video

Test Artifacts
Explore Page > should verify order of search results Screenshots Video

Review all test suite changes for PR #15239 ↗︎

Copy link
Contributor

github-actions bot commented Mar 6, 2024

The Java checkstyle failed.

Please run mvn spotless:apply in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

Copy link

sonarqubecloud bot commented Mar 7, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@ShaileshParmar11 ShaileshParmar11 enabled auto-merge (squash) March 7, 2024 10:14
@ShaileshParmar11 ShaileshParmar11 merged commit 78d6b72 into main Mar 7, 2024
13 of 16 checks passed
@ShaileshParmar11 ShaileshParmar11 deleted the cy-ts branch March 7, 2024 11:36
ShaileshParmar11 added a commit that referenced this pull request Mar 20, 2024
* chore(ui): typescript support for cypress tests

* convert all js to ts

* fix more types

* fix more types

* updated config for ts file

* fixed failing cypress test

* fixed DQ cypress

* fixed dq flaky test

---------

Co-authored-by: Shailesh Parmar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e:Governance e2e:Integration e2e:Observability safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants