Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ui): cypress create uniq glossary for the tests #15073

Merged
merged 2 commits into from
Feb 8, 2024
Merged

test(ui): cypress create uniq glossary for the tests #15073

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c3fb867
test(ui): cypress create uniq glossary for the tests
chirag-madlani Feb 7, 2024
666a276
Merge branch 'main' into fix-glossary-cy
chirag-madlani Feb 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 14 additions & 10 deletions openmetadata-ui/src/main/resources/ui/cypress/common/Entities/EntityClass.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,8 @@ const domainDetails2 = {
};

const glossaryDetails1 = {
name: 'CypressGeneral',
displayName: 'Cypress General',
name: `Cypress%General ${uuid()}`,
displayName: `Cypress % General ${uuid()}`,
description:
'Glossary terms that describe general conceptual terms. **Note that these conceptual terms are used for automatically labeling the data.**',
reviewers: [],
Expand All @@ -92,8 +92,8 @@ const glossaryDetails1 = {
};

const glossaryDetails2 = {
name: 'CypressPerson',
displayName: 'Cypress Person',
name: `Cypress%Person ${uuid()}`,
displayName: `Cypress % Person ${uuid()}`,
description:
// eslint-disable-next-line max-len
'Glossary related to describing **conceptual** terms related to a Person. These terms are used to label data assets to describe the user data in those assets. Example - a table column can be labeled with Person.PhoneNumber tag. The associated PII and PersonalData tags are automatically applied.',
Expand All @@ -112,7 +112,7 @@ const glossaryTermDetails1 = {
mutuallyExclusive: false,
tags: [],
style: {},
glossary: 'CypressGeneral',
glossary: glossaryDetails1.name,
};

const glossaryTermDetails2 = {
Expand All @@ -125,7 +125,7 @@ const glossaryTermDetails2 = {
mutuallyExclusive: false,
tags: [],
style: {},
glossary: 'CypressPerson',
glossary: glossaryDetails2.name,
};

class EntityClass {
Expand Down Expand Up @@ -320,24 +320,28 @@ class EntityClass {
});
// Glossary 1 to test
deleteEntityViaREST({
entityName: `${glossaryDetails1.name}.${glossaryTermDetails1.name}`,
entityName: `${encodeURIComponent(glossaryDetails1.name)}.${
glossaryTermDetails1.name
}`,
endPoint: EntityType.GlossaryTerm,
token,
});
// Glossary 2 to test
deleteEntityViaREST({
entityName: `${glossaryDetails2.name}.${glossaryTermDetails2.name}`,
entityName: `${encodeURIComponent(glossaryDetails2.name)}.${
glossaryTermDetails2.name
}`,
endPoint: EntityType.GlossaryTerm,
token,
});
// Glossary 2 to test
deleteEntityViaREST({
entityName: glossaryDetails1.name,
entityName: encodeURIComponent(glossaryDetails1.name),
endPoint: EntityType.Glossary,
token,
});
deleteEntityViaREST({
entityName: glossaryDetails2.name,
entityName: encodeURIComponent(glossaryDetails2.name),
endPoint: EntityType.Glossary,
token,
});
Expand Down
Loading