Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#14387 UI: Test case values not loading on first edit, shows up on second #14773

Merged
merged 3 commits into from
Jan 19, 2024

Conversation

ShaileshParmar11
Copy link
Contributor

@ShaileshParmar11 ShaileshParmar11 commented Jan 18, 2024

Describe your changes:

Fixes #14387
fixed UI: Test case values not loading on first edit, shows up on second

Screen.Recording.2024-01-18.at.5.13.46.PM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs labels Jan 18, 2024
@ShaileshParmar11 ShaileshParmar11 self-assigned this Jan 18, 2024
@ShaileshParmar11 ShaileshParmar11 added the e2e This will trigger e2e test workflows label Jan 18, 2024
Copy link

cypress bot commented Jan 18, 2024

3 failed tests on run #32997 ↗︎

3 609 32 0 Flakiness 0

Details:

Merge branch 'main' into issue-14387
Project: openmetadata Commit: 828d8ccffb
Status: Failed Duration: 33:33 💡
Started: Jan 19, 2024 10:06 AM Ended: Jan 19, 2024 10:39 AM
Failed  Service/ServiceIngestion.spec.ts • 2 failed tests • cypress-ci-psql-oss-7582099474-1

View Output Video

Test Artifacts
S3 Ingestion > Update description and verify description after re-run Screenshots Video
Mysql Ingestion > Update description and verify description after re-run Screenshots Video
Failed  Pages/GlossaryVersionPage.spec.js • 1 failed test • cypress-ci-psql-oss-7582099474-1

View Output Video

Test Artifacts
Glossary and glossary term version pages should work properly > Glossary term version page should display owner and reviewer changes properly Screenshots Video

Review all test suite changes for PR #14773 ↗︎

Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 52%
52.58% (26867/51094) 35.06% (10713/30555) 33.49% (3134/9358)

Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ShaileshParmar11 ShaileshParmar11 enabled auto-merge (squash) January 19, 2024 12:23
@chirag-madlani chirag-madlani merged commit dc02fbb into main Jan 19, 2024
13 of 20 checks passed
@chirag-madlani chirag-madlani deleted the issue-14387 branch January 19, 2024 16:51
Abhishek332 pushed a commit to Abhishek332/OpenMetadata that referenced this pull request Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e This will trigger e2e test workflows safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI: Test case values not loading on first edit, shows up on second
3 participants