fix(ui): Delete widget not working with other lang #14769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chirag-madlani
added
e2e
github-actions
bot
added
the
safe to test
Jest test CoverageUI tests summary
|
9 failed tests on run #33027 ↗︎
Details:
|
||||||||||||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| BigQuery Ingestion > Create & Ingest BigQuery service |
Screenshots
Video
|
|
Pages/Users.spec.ts • 1 failed test • cypress-ci-psql-oss-7629621943-1
| Test | Artifacts | |
|---|---|---|
| User with different Roles > Update own admin details |
Screenshots
Video
|
|
Service/redshiftWithDBT.spec.js • 2 failed tests • cypress-ci-psql-oss-7629621943-1
| Test | Artifacts | |
|---|---|---|
| RedShift Ingestion > Add DBT ingestion |
Screenshots
Video
|
|
| RedShift Ingestion > Validate DBT is ingested properly |
Screenshots
Video
|
|
Pages/DataInsight.spec.js • 1 failed test • cypress-ci-psql-oss-7629621943-1
| Test | Artifacts | |
|---|---|---|
| Data Insight feature > Deploy data insight index |
Screenshots
Video
|
|
Features/RecentlyViewed.spec.js • 1 failed test • cypress-ci-psql-oss-7629621943-1
| Test | Artifacts | |
|---|---|---|
| Recently viwed data assets > recently view section should have at max list of 5 entity |
Screenshots
Video
|
|
The first 5 failed specs are shown, see all 7 specs in Cypress Cloud.
Review all test suite changes for PR #14769 ↗︎
…a/OpenMetadata into delete-localisation
harshach
approved these changes
Jan 23, 2024
|
Sachin-chaurasiya
approved these changes
Jan 23, 2024
There was a problem hiding this comment.
@chirag-madlani , As we have made some changes to the common component, so please check the collate side changes as well, thanks
Abhishek332
pushed a commit
to Abhishek332/OpenMetadata
that referenced
this pull request
Jan 25, 2024
* fix(ui): Delete widget not working with other lang * fix cypress tests * fix tests * fix udpate displayName issue * fix tests * fix owner issue * fix failures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Fixes Delete widget issue for other langs
DELETEalso translated to the target lang but validation is still on workDELETEDELETEtranslation for other lang so it will in sync with validation and work.Screen.Recording.2024-01-18.at.11.34.25.AM.mov
I worked on ... because ...
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>