Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: Snowflake - Add Support For Materialised Views #14664

Merged
merged 2 commits into from
Jan 10, 2024
Merged

Minor: Snowflake - Add Support For Materialised Views #14664

merged 2 commits into from
Jan 10, 2024

Conversation

ulixius9
Copy link
Member

Describe your changes:

Snowflake - Add Support For Materialised Views

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@ulixius9 ulixius9 requested a review from a team as a code owner January 10, 2024 07:16
@github-actions github-actions bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Jan 10, 2024
OnkarVO7
OnkarVO7 previously approved these changes Jan 10, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
46.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ulixius9 ulixius9 requested a review from OnkarVO7 January 10, 2024 13:05
@ulixius9 ulixius9 merged commit 8197fe5 into main Jan 10, 2024
13 checks passed
@ulixius9 ulixius9 deleted the snowflake_mview branch January 10, 2024 13:06
ulixius9 added a commit that referenced this pull request Jan 10, 2024
@ulixius9
Minor: Snowflake - Add Support For Materialised Views (#14664)
07d157f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OnkarVO7 OnkarVO7 OnkarVO7 approved these changes

Assignees
No one assigned
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ulixius9 @OnkarVO7