Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: Fix postgres version on docs #14642

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Minor: Fix postgres version on docs #14642

merged 1 commit into from
Jan 10, 2024

Conversation

ulixius9
Copy link
Member

@ulixius9 ulixius9 commented Jan 9, 2024

Describe your changes:

Our docker image already uses postgres version 15 hence the docs are misleading, also here we already state that the version supported is 12 or greater

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added documentation Improvements or additions to documentation Ingestion safe to test Add this label to run secure Github workflows on PRs labels Jan 9, 2024
@ulixius9 ulixius9 merged commit 616e3bd into main Jan 10, 2024
18 checks passed
@ulixius9 ulixius9 deleted the deployment_docs_fix branch January 10, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akash-jain-10 akash-jain-10 akash-jain-10 approved these changes

@ayush-shah ayush-shah ayush-shah approved these changes

@tutte tutte Awaiting requested review from tutte

@harshach harshach Awaiting requested review from harshach

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ulixius9 @akash-jain-10 @ayush-shah