Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow user login using username and reassign roles based on users' ldap groups when login #14550

Merged
merged 5 commits into from
Jan 5, 2024
Merged

Allow user login using username and reassign roles based on users' ldap groups when login #14550

merged 5 commits into from
Jan 5, 2024

Conversation

harshach
Copy link
Collaborator

@harshach harshach commented Jan 3, 2024

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@harshach harshach requested review from a team, karanh37 and chirag-madlani as code owners January 3, 2024 01:01
@github-actions github-actions bot added UI UI specific issues backend safe to test Add this label to run secure Github workflows on PRs labels Jan 3, 2024
@harshach harshach mentioned this pull request Jan 3, 2024
Closed
9 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2024

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 49%
 50.06% (25087/50117) 32.85% (9903/30148) 31.35% (2863/9131)

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 3, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 3, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@harshach
Copy link
Collaborator Author

harshach commented Jan 4, 2024

@chirag-madlani @karanh37 can one of you review this

@chirag-madlani chirag-madlani merged commit 34ff582 into main Jan 5, 2024
22 checks passed
@chirag-madlani chirag-madlani deleted the ldap-feature-v2 branch January 5, 2024 05:16
@chirag-madlani
Copy link
Collaborator

@harshach Merged it. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@mohityadav766 mohityadav766 mohityadav766 approved these changes

@karanh37 karanh37 Awaiting requested review from karanh37

Assignees
No one assigned
Labels
backend safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@harshach @chirag-madlani @mohityadav766 @EricWent