MINOR - Create Test Case Resolution ts entry & delete resolution when… #14541
Conversation
… Test Case is deleted
github-actions
bot
added
backend
Ingestion
safe to test
openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/TestCaseRepository.java
Outdated
Show resolved
Hide resolved
|
The Java checkstyle failed. Please run You can install the pre-commit hooks with |
|
The Java checkstyle failed. Please run You can install the pre-commit hooks with |
|
|
||
| @ConnectionAwareSqlQuery( | ||
| value = | ||
| "SELECT json FROM data_quality_data_time_series where entityFQNHash = :testCaseFQNHash " |
There was a problem hiding this comment.
its worth promoting incidentId as field at top level and add a index insted of doing JSON_EXTRACT
There was a problem hiding this comment.
yup, will change that
| String jsonThread = | ||
| Entity.getCollectionDAO() | ||
| .feedDAO() | ||
| .fetchThreadByTestCaseResolutionStatusId(incident.getStateId()); |
There was a problem hiding this comment.
I hope we are encoding this in entityLink such that we can retrieve all the incidents(tasks) that belong to a test case along with a particular incident
| /** | ||
| * Check all the test case results that have an ongoing incident and get the stateId of the incident | ||
| */ | ||
| private List<UUID> getIncidentIds(TestCase test) { |
There was a problem hiding this comment.
this is going to be an expensive call
|
… Test Case is deleted
Describe your changes:
testCaseResolutionStatusReferencefield, but it did not add the entry ontest_case_resolution_status_time_seriestime series tabletest_case_resolution_status_time_seriesentriesType of change:
Checklist:
Fixes <issue-number>: <short explanation>