Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): Entity with special characters causing permission API failure and causing page load failure #14538

Merged
merged 1 commit into from
Jan 2, 2024
Merged

fix(ui): Entity with special characters causing permission API failure and causing page load failure #14538

merged 1 commit into from
Jan 2, 2024

Conversation

chirag-madlani
Copy link
Collaborator

Describe your changes:

Fixes issue with encoding on permission

Screen.Recording.2024-01-02.at.3.21.58.PM.mov

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs labels Jan 2, 2024
@chirag-madlani chirag-madlani added the e2e This will trigger e2e test workflows label Jan 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2024

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 49%
 50.09% (25092/50092) 32.87% (9901/30125) 31.38% (2863/9125)

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 2, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@cypress Cypress
Copy link

cypress bot commented Jan 2, 2024 •
edited
Loading

19 failed tests on run #32767 ↗︎

19 477 8 0 Flakiness 0

Details:

fix(ui): pass encoded fqn to fetch table permission
Project: openmetadata Commit: 2eda2d987e
Status: Failed Duration: 40:50 💡
Started: Jan 2, 2024 10:21 AM Ended: Jan 2, 2024 11:02 AM
Failed  Service/postgres.spec.js • 2 failed tests • cypress-ci-mysql-oss-7384466585-1

View Output Video

Test Artifacts
Postgres Ingestion > Update table description and verify description after re-run Screenshots Video
Postgres Ingestion > Verify if usage is ingested properly Screenshots Video
Failed  Pages/ServiceVersionPage.spec.js • 1 failed test • cypress-ci-mysql-oss-7384466585-1

View Output Video

Test Artifacts
Common prerequisite for service version test > Search service version page > Search version page should show version details after soft deleted Screenshots Video
Failed  Flow/AddAndRemoveTierAndOwner.spec.js • 4 failed tests • cypress-ci-mysql-oss-7384466585-1

View Output Video

Test Artifacts
Add and Remove Owner > table details page Screenshots Video
Add and Remove Owner > dashboard details page Screenshots Video
Add and Remove Owner > storedProcedure details page Screenshots Video
Add and Remove Owner > Test suite details page Screenshots Video
Failed  Pages/DataQualityAndProfiler.spec.js • 3 failed tests • cypress-ci-mysql-oss-7384466585-1

View Output Video

Test Artifacts
Data Quality and Profiler should work properly > Add test case to logical test suite Screenshots Video
Data Quality and Profiler should work properly > Remove test case from logical test suite Screenshots Video
Data Quality and Profiler should work properly > Delete test suite Screenshots Video
Failed  Pages/SearchIndexDetails.spec.js • 2 failed tests • cypress-ci-mysql-oss-7384466585-1

View Output Video

Test Artifacts
SearchIndexDetails page should work properly for data steward role > All permissible actions on search index details page should work properly Screenshots Video
SearchIndexDetails page should work properly for admin role > All permissible actions on search index details page should work properly Screenshots Video

The first 5 failed specs are shown, see all 11 specs in Cypress Cloud.

Review all test suite changes for PR #14538 ↗︎

@chirag-madlani chirag-madlani merged commit a457e7a into main Jan 2, 2024
20 of 32 checks passed
@chirag-madlani chirag-madlani deleted the fix-encoding branch January 2, 2024 12:02
chirag-madlani added a commit that referenced this pull request Jan 4, 2024
@chirag-madlani
fix(ui): pass encoded fqn to fetch table permission (#14538)
ec20959 
(cherry picked from commit a457e7a)
@harshach harshach changed the title fix(ui): pass encoded fqn to fetch table permission fix(ui): Entity with special characters causing permission API failure and causing page load failure Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karanh37 karanh37 karanh37 approved these changes

@ayush-shah ayush-shah ayush-shah approved these changes

@aniketkatkar97 aniketkatkar97 aniketkatkar97 approved these changes

@harshach harshach Awaiting requested review from harshach

Assignees
No one assigned
Labels
e2e This will trigger e2e test workflows safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chirag-madlani @karanh37 @ayush-shah @aniketkatkar97