Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: #14486 filter current user from reviewer list #14495

Merged
merged 1 commit into from
Dec 26, 2023
Merged

Conversation

chirag-madlani
Copy link
Collaborator

@chirag-madlani chirag-madlani commented Dec 25, 2023

Describe your changes:

Fixes #14486

  • Filter current user from reviewers list

I worked on

  • Filter current user from reviewers list
  • Fix the user profile loading issue for the reviewer and owner field in the glossary form
  • Improve some cypress and unit tests
Screen.Recording.2023-12-25.at.5.29.47.PM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 49%
49.86% (25002/50145) 32.7% (9878/30209) 31.07% (2839/9136)

Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

cypress bot commented Dec 25, 2023

19 failed tests on run #32717 ↗︎

19 477 8 0 Flakiness 0

Details:

FIX: #14486 filter current user from reviewer list
Project: openmetadata Commit: 0e380ccc14
Status: Failed Duration: 38:28 💡
Started: Dec 25, 2023 12:21 PM Ended: Dec 25, 2023 1:00 PM
Failed  Service/postgres.spec.js • 2 failed tests • cypress-ci-mysql-oss-7321591303-1

View Output Video

Test Artifacts
Postgres Ingestion > Update table description and verify description after re-run Screenshots Video
Postgres Ingestion > Verify if usage is ingested properly Screenshots Video
Failed  Flow/AddAndRemoveTierAndOwner.spec.js • 4 failed tests • cypress-ci-mysql-oss-7321591303-1

View Output Video

Test Artifacts
Add and Remove Owner > table details page Screenshots Video
Add and Remove Owner > topic details page Screenshots Video
Add and Remove Owner > storedProcedure details page Screenshots Video
Add and Remove Owner > Glossary details page Screenshots Video
Failed  Pages/SearchIndexDetails.spec.js • 2 failed tests • cypress-ci-mysql-oss-7321591303-1

View Output Video

Test Artifacts
SearchIndexDetails page should work properly for data steward role > All permissible actions on search index details page should work properly Screenshots Video
SearchIndexDetails page should work properly for admin role > All permissible actions on search index details page should work properly Screenshots Video
Failed  Pages/Users.spec.js • 3 failed tests • cypress-ci-mysql-oss-7321591303-1

View Output Video

Test Artifacts
Users flow should work properly > Restore soft deleted user Screenshots Video
Users flow should work properly > Permanently Delete Soft Deleted User Screenshots Video
Admin flow should work properly > Personal Access Token flow should work properly > Update token expiration for 30 days Screenshots Video
Failed  Service/mysql.spec.js • 1 failed test • cypress-ci-mysql-oss-7321591303-1

View Output Video

Test Artifacts
MySQL Ingestion > Update table description and verify description after re-run Screenshots Video

The first 5 failed specs are shown, see all 10 specs in Cypress Cloud.

Review all test suite changes for PR #14495 ↗︎

@chirag-madlani chirag-madlani merged commit 8746058 into main Dec 26, 2023
20 of 34 checks passed
@chirag-madlani chirag-madlani deleted the fix-14486 branch December 26, 2023 05:11
chirag-madlani added a commit that referenced this pull request Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e This will trigger e2e test workflows safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disallow changing reviewers when creating a term
2 participants