Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: AIRFLOW_DB_PROPERTIES default value in docker compose files #14274

Merged
merged 1 commit into from
Dec 6, 2023
Merged

fix: AIRFLOW_DB_PROPERTIES default value in docker compose files #14274

merged 1 commit into from
Dec 6, 2023

Conversation

akash-jain-10
Copy link
Collaborator

AIRFLOW_DB_PROPERTIES default value in docker compose files.

As per the official documentation, the double quotes and single quotes are not parsed by docker-compose environment section and container creates the environment variable with the double quotes as the value instead of blank.

Ref - https://docs.docker.com/compose/environment-variables/set-environment-variables/#use-the-environment-attribute

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@akash-jain-10 akash-jain-10 requested review from harshach and a team as code owners December 6, 2023 13:48
@akash-jain-10 akash-jain-10 self-assigned this Dec 6, 2023
@github-actions github-actions bot added Ingestion devops safe to test Add this label to run secure Github workflows on PRs labels Dec 6, 2023
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 6, 2023

[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@akash-jain-10 akash-jain-10 merged commit 6eefd51 into main Dec 6, 2023
@akash-jain-10 akash-jain-10 deleted the fix-docker-compose-env-db-properties branch December 6, 2023 14:26
akash-jain-10 added a commit that referenced this pull request Dec 6, 2023
@akash-jain-10
fix: AIRFLOW_DB_PROPERTIES default value in docker compose files (#…
04d83ce 
…14274)

(cherry picked from commit 6eefd51)
MrVinegar pushed a commit to MrVinegar/OpenMetadata that referenced this pull request Dec 15, 2023
@akash-jain-10
fix: AIRFLOW_DB_PROPERTIES default value in docker compose files (o…
ab06b62 
…pen-metadata#14274)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvinmaniar123 dhruvinmaniar123 dhruvinmaniar123 approved these changes

@harshach harshach Awaiting requested review from harshach harshach is a code owner

@ulixius9 ulixius9 Awaiting requested review from ulixius9

Assignees

@akash-jain-10 akash-jain-10

Labels
devops Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akash-jain-10 @dhruvinmaniar123