Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#14235: adding dialect based on connection type to LineageParser #14249

Merged
merged 6 commits into from
Dec 8, 2023
Merged

#14235: adding dialect based on connection type to LineageParser #14249

merged 6 commits into from
Dec 8, 2023

Conversation

LucasGarcia07
Copy link
Contributor

Describe your changes:

Fixes 14235, adding dialect based on db_service_name to the LineageParser.

I worked on because I'm create lineage based on bigquery dialect and sqlfluff fails when use ansi dialect to validate.

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@LucasGarcia07 LucasGarcia07 requested a review from a team as a code owner December 5, 2023 13:44
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2023

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@LucasGarcia07
Copy link
Contributor Author

@harshach

@harshach harshach added the safe to test Add this label to run secure Github workflows on PRs label Dec 5, 2023
@harshach
Copy link
Collaborator

harshach commented Dec 5, 2023

Thanks @LucasGarcia07 for the contribution.
@ulixius9 can you do a review

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2023

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@ulixius9 ulixius9 changed the title Fix #14235: adding dialect based on connection type to LineageParser #14235: adding dialect based on connection type to LineageParser Dec 6, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 7, 2023

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 8, 2023

[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

83.3% 83.3% Coverage
0.0% 0.0% Duplication

@ulixius9
Copy link
Member

ulixius9 commented Dec 8, 2023

Thanks @LucasGarcia07 for the pr ❤️

@ulixius9 ulixius9 merged commit fe06b5c into open-metadata:main Dec 8, 2023
MrVinegar pushed a commit to MrVinegar/OpenMetadata that referenced this pull request Dec 15, 2023
@LucasGarcia07 @ulixius9
open-metadata#14235: adding dialect based on connection type to Linea…
4554d50 
…geParser (open-metadata#14249)

* Fix open-metadata#14235: adding dialect based on connection type to LineageParser

* Fix: formating changes

* Update ingestion/src/metadata/ingestion/source/dashboard/metabase/metadata.py

Co-authored-by: Mayur Singal <[email protected]>

* style: fix indentation errors

* Fix pytest

---------

Co-authored-by: LucasGarcia07 <[email protected]>
Co-authored-by: ulixius9 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulixius9 ulixius9 ulixius9 approved these changes

Assignees

@ulixius9 ulixius9

Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LucasGarcia07 @harshach @ulixius9