Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

working on lineage es integration #14181

Merged
merged 65 commits into from
Jan 9, 2024
Merged

working on lineage es integration #14181

merged 65 commits into from
Jan 9, 2024

Conversation

07Himank
Copy link
Contributor

@07Himank 07Himank commented Nov 30, 2023

I worked on ... because ... [ WIP ] working on lineage es integration

Fixes #8680
Fixes #12609
Fixes #11795
Fixes #13119
Fixes #11515
Fixes #14048

image

Type of change:

  • [ x] Improvement

@07Himank 07Himank added the safe to test Add this label to run secure Github workflows on PRs label Nov 30, 2023
@07Himank 07Himank requested a review from a team as a code owner November 30, 2023 06:28
@07Himank 07Himank marked this pull request as draft November 30, 2023 06:28
Copy link
Contributor

The Java checkstyle failed.

Please run mvn googleformatter:format@reformat-sources in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@github-actions github-actions bot added the UI UI specific issues label Dec 14, 2023
Copy link
Contributor

github-actions bot commented Jan 8, 2024

The Java checkstyle failed.

Please run mvn spotless:apply in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

Copy link
Contributor

github-actions bot commented Jan 8, 2024

The Java checkstyle failed.

Please run mvn spotless:apply in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

Copy link
Contributor

github-actions bot commented Jan 8, 2024

The Java checkstyle failed.

Please run mvn spotless:apply in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

Copy link
Contributor

github-actions bot commented Jan 8, 2024

The Java checkstyle failed.

Please run mvn spotless:apply in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

Copy link
Contributor

github-actions bot commented Jan 8, 2024

The Java checkstyle failed.

Please run mvn spotless:apply in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

relationshipDetails.put("toEntity", toDetails);
if (lineageDetails != null) {
relationshipDetails.put(
"pipeline",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this could be pipeline or stored procedure as an edge cc @pmbrull

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@07Himank need to address this, it can be pipeline or stored procedure here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harshach just key name is pipeline but it works for both pipeline and stored procedure .. do you want to me change the key name?

if (depth <= 0) {
return;
}
es.org.elasticsearch.action.search.SearchRequest searchRequest =
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we move this into import

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harshach We have two SearchRequest one is internal that why we use it this way.

Copy link
Contributor

github-actions bot commented Jan 9, 2024

The Java checkstyle failed.

Please run mvn spotless:apply in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@07Himank 07Himank changed the title [ WIP ] working on lineage es integration working on lineage es integration Jan 9, 2024
@07Himank 07Himank marked this pull request as ready for review January 9, 2024 11:47
Copy link

sonarqubecloud bot commented Jan 9, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

The SonarCloud Quality Gate passed, but some issues were introduced.

4 New issues
0 Security Hotspots
0.0% Coverage on New Code
1.2% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarqubecloud bot commented Jan 9, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@harshach harshach merged commit 44af8b3 into main Jan 9, 2024
23 checks passed
@harshach harshach deleted the lineageEsIntegration branch January 9, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
4 participants