Update ingestion_dependency.sh #14139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
preetsshah
requested review from
akash-jain-10,
harshach and
a team
as code owners
akash-jain-10
previously approved these changes
Nov 30, 2023
akash-jain-10
added
the
safe to test
akash-jain-10
approved these changes
Dec 4, 2023
|
[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!
|
akash-jain-10
pushed a commit
that referenced
this pull request
Dec 4, 2023
* Update ingestion_dependency.sh * Add parameter for DB connection properties --------- Co-authored-by: Akash Jain <[email protected]> (cherry picked from commit 20cf8f6)
MrVinegar
pushed a commit
to MrVinegar/OpenMetadata
that referenced
this pull request
Dec 15, 2023
* Update ingestion_dependency.sh * Add parameter for DB connection properties --------- Co-authored-by: Akash Jain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
I worked on updating the way database connection is established in ingestion_dependency.sh script because the current way it is done requires modification in the container file using "sed" command. File - "/opt/airflow/airflow.cfg" is modified in order to feed the database connection string. However, as per this doc, we can export the connection string in environment variable and db connection can still be established. This way, no file modification is required.
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>