Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump(ui): node version to fix node-gyp error #14129

Merged
merged 5 commits into from
Nov 28, 2023
Merged

Conversation

chirag-madlani
Copy link
Collaborator

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs labels Nov 27, 2023
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 48%
48.57% (23681/48755) 30.33% (8864/29230) 30.13% (2683/8905)

@chirag-madlani chirag-madlani enabled auto-merge (squash) November 28, 2023 05:06
Copy link

[open-metadata-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@chirag-madlani chirag-madlani merged commit 9a55b38 into main Nov 28, 2023
@chirag-madlani chirag-madlani deleted the fix-node-gyp branch November 28, 2023 06:13
Sachin-chaurasiya pushed a commit that referenced this pull request Dec 6, 2023
* bump(ui): node version to fix node-gyp error

* enable logs

* fix node-gyp

* eliminate remove command

* revert to silent build

(cherry picked from commit 9a55b38)
MrVinegar pushed a commit to MrVinegar/OpenMetadata that referenced this pull request Dec 15, 2023
* bump(ui): node version to fix node-gyp error

* enable logs

* fix node-gyp

* eliminate remove command

* revert to silent build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants