Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui): add entity right panel component #14108

Merged
merged 3 commits into from
Nov 27, 2023

Conversation

Sachin-chaurasiya
Copy link
Contributor

Describe your changes:

I worked on creating the right panel component for entities. This component will eliminate duplicate code from entity pages, providing a shared component to render the right panel content. Additionally, if we need to display any common widgets in the right panel, we only have to make changes in one place.

Type of change:

  • Improvement

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Sachin-chaurasiya Sachin-chaurasiya self-assigned this Nov 24, 2023
@github-actions github-actions bot added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs labels Nov 24, 2023
Copy link
Contributor

github-actions bot commented Nov 24, 2023

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 48%
48.65% (23684/48681) 30.41% (8862/29145) 30.18% (2684/8892)

Copy link

[open-metadata-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Collaborator

@chirag-madlani chirag-madlani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sachin-chaurasiya we wanted to make this right panel as resizable. You can work on them next
Thanks for the cleanup!
🚀

@chirag-madlani chirag-madlani merged commit 84054a8 into main Nov 27, 2023
@chirag-madlani chirag-madlani deleted the entity-right-panel-component branch November 27, 2023 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants