Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove quotes around fqn for domain #14055

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Conversation

karanh37
Copy link
Contributor

Describe your changes:

Fixes incorrect count issue for domains having dot in their names.

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs labels Nov 21, 2023
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 48%
48.67% (23651/48591) 30.41% (8860/29139) 30.2% (2679/8872)

Copy link

[open-metadata-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@chirag-madlani chirag-madlani merged commit 9c990fe into main Nov 22, 2023
@chirag-madlani chirag-madlani deleted the domain-fqn-quote-issue branch November 22, 2023 08:22
karanh37 added a commit that referenced this pull request Nov 28, 2023
karanh37 added a commit that referenced this pull request Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants