fix: allow config update for external app #14034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
UI
Jest test CoverageUI tests summary
|
… into fix-appConfig
|
The Python checkstyle failed. Please run You can install the pre-commit hooks with |
pmbrull
reviewed
Nov 22, 2023
| "$ref": "internal/dataInsightsReportAppConfig.json" | ||
| }, | ||
| { | ||
| "$ref": "internal/searchIndexingAppConfig.json" |
pmbrull
reviewed
Nov 22, 2023
| } | ||
| } | ||
| "allowConfiguration": false, | ||
| "appConfiguration": {} |
There was a problem hiding this comment.
cleaning data insights app config and configuring it directly in the backend, since we don't allow it to be configured via the UI.
mohityadav766
previously approved these changes
Nov 27, 2023
harshach
reviewed
Nov 27, 2023
...ta-service/src/main/java/org/openmetadata/service/apps/bundles/insights/DataInsightsApp.java
Outdated
Show resolved
Hide resolved
harshach
reviewed
Nov 27, 2023
...ta-service/src/main/java/org/openmetadata/service/apps/bundles/insights/DataInsightsApp.java
Outdated
Show resolved
Hide resolved
|
[open-metadata-airflow-apis] Kudos, SonarCloud Quality Gate passed! |
|
[open-metadata-ui] Kudos, SonarCloud Quality Gate passed! |
|
[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed! |
harshach
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Allow configuration update for External Apps.
part of https://github.com/open-metadata/openmetadata-collate/issues/154
I worked on ... because ...
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>