Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Backend Support for Custom Metrics #13965

Merged
merged 4 commits into from
Nov 17, 2023
Merged

Feat: Backend Support for Custom Metrics #13965

merged 4 commits into from
Nov 17, 2023

Conversation

TeddyCr
Copy link
Contributor

@TeddyCr TeddyCr commented Nov 13, 2023

Describe your changes:

  • implemented backend support for column and table custom metrics

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Improvement

  • I have added tests around the new logic.
  • For connector/ingestion changes: I updated the documentation.

@TeddyCr TeddyCr requested a review from a team as a code owner November 13, 2023 21:25
@github-actions github-actions bot added backend Ingestion safe to test Add this label to run secure Github workflows on PRs labels Nov 13, 2023
@TeddyCr TeddyCr requested a review from a team as a code owner November 14, 2023 08:48
@TeddyCr TeddyCr enabled auto-merge (squash) November 17, 2023 13:03
@TeddyCr TeddyCr merged commit f3da919 into open-metadata:main Nov 17, 2023
@sonarqubecloud SonarQubeCloud
Copy link

[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohityadav766 mohityadav766 mohityadav766 approved these changes

Assignees
No one assigned
Labels
backend Backward-Incompatible-Change Ingestion profiler safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TeddyCr @mohityadav766