Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ui): change github start modal to popup #13948

Merged
merged 4 commits into from
Nov 13, 2023
Merged

chore(ui): change github start modal to popup #13948

merged 4 commits into from
Nov 13, 2023

Conversation

chirag-madlani
Copy link
Collaborator

@chirag-madlani chirag-madlani commented Nov 11, 2023 •
edited
Loading

Describe your changes:

Screenshot 2023-11-12 at 11 40 46 AM
Screen.Recording.2023-11-11.at.2.16.00.PM.mov

Fixes

  • I worked on fixing cypress
  • change modal to popup

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs labels Nov 11, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 11, 2023 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 48%
 48.8% (23646/48457) 30.43% (8851/29089) 30.26% (2679/8853)

ShaileshParmar11
ShaileshParmar11 previously approved these changes Nov 11, 2023
View reviewed changes
Copy link
Contributor

@ShaileshParmar11 ShaileshParmar11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment but not blocker.

@cypress Cypress
Copy link

cypress bot commented Nov 11, 2023

16 failed tests on run #32269 ↗︎

16 456 27 0 Flakiness 0

Details:

chore(ui): change github start modal to popup
Project: openmetadata Commit: 59e3dde9d3
Status: Failed Duration: 35:48 💡
Started: Nov 11, 2023 7:05 AM Ended: Nov 11, 2023 8:41 AM
Failed  Features/QueryEntity.spec.js • 1 failed test • cypress-ci-mysql-oss-6832721582-1

View
Output
Video

Test Artifacts
Query Entity > Visit full screen view of query Screenshots Video
Failed  Features/SchemaSearch.spec.js • 1 failed test • cypress-ci-mysql-oss-6832721582-1

View
Output
Video

Test Artifacts
Schema search > Search schema in database page Screenshots Video
Failed  Pages/DataInsightSettings.spec.js • 2 failed tests • cypress-ci-mysql-oss-6832721582-1

View
Output
Video

Test Artifacts
Data Insight settings page should work properly > Uninstall application Screenshots Video
Data Insight settings page should work properly > Install application Screenshots Video
Failed  Pages/DataModelVersionPage.spec.js • 5 failed tests • cypress-ci-mysql-oss-6832721582-1

View
Output
Video

Test Artifacts
Data model version page should work properly > Data model version page should show description and tag changes properly Screenshots Video
Data model version page should work properly > Data model version page should show removed tags changes properly Screenshots Video
Data model version page should work properly > Data model version page should show owner changes properly Screenshots Video
Data model version page should work properly > Data model version page should show tier changes properly Screenshots Video
Data model version page should work properly > Cleanup for data model version page test Screenshots Video
Failed  Pages/Tags.spec.js • 2 failed tests • cypress-ci-mysql-oss-6832721582-1

View
Output
Video

Test Artifacts
Tags page should work > Add new tag flow should work properly Screenshots Video
Tags page should work > Delete Tag flow should work properly Screenshots Video

The first 5 failed specs are shown, see all 7 specs in Cypress Cloud.

Review all test suite changes for PR #13948 ↗︎

@Ashish8689 Ashish8689 marked this pull request as ready for review November 11, 2023 09:56
chirag-madlani
chirag-madlani commented Nov 11, 2023
View reviewed changes
Copy link
Collaborator Author

@chirag-madlani chirag-madlani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harshach Please review

@harshach
Copy link
Collaborator

@chirag-madlani @Ashish8689 can we keep the size bit smaller , similar to whats new pop up

@sonarqubecloud SonarQubeCloud
Copy link

[open-metadata-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@chirag-madlani chirag-madlani merged commit 3fdc71a into main Nov 13, 2023
@chirag-madlani chirag-madlani deleted the github-star-improvements branch November 13, 2023 04:56
Sachin-chaurasiya pushed a commit that referenced this pull request Nov 13, 2023
@chirag-madlani @Sachin-chaurasiya
chore(ui): change github start modal to popup (#13948)
f8824ca 
(cherry picked from commit 3fdc71a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ashish8689 Ashish8689 Ashish8689 left review comments

@Sachin-chaurasiya Sachin-chaurasiya Sachin-chaurasiya approved these changes

@ShaileshParmar11 ShaileshParmar11 ShaileshParmar11 approved these changes

@harshach harshach Awaiting requested review from harshach

@karanh37 karanh37 Awaiting requested review from karanh37

Assignees

@chirag-madlani chirag-madlani

@Ashish8689 Ashish8689

Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chirag-madlani @harshach @Sachin-chaurasiya @Ashish8689 @ShaileshParmar11