Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ElasticSearch: Fix ES connection #13919

Merged
merged 5 commits into from
Nov 13, 2023
Merged

ElasticSearch: Fix ES connection #13919

merged 5 commits into from
Nov 13, 2023

Conversation

ulixius9
Copy link
Member

@ulixius9 ulixius9 commented Nov 9, 2023

Describe your changes:

Fixes #13800

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added backend Ingestion safe to test Add this label to run secure Github workflows on PRs documentation Improvements or additions to documentation UI UI specific issues devops labels Nov 9, 2023
Copy link
Contributor

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 48%
49.09% (23664/48202) 30.57% (8852/28961) 30.43% (2684/8821)

@github-actions github-actions bot removed documentation Improvements or additions to documentation devops labels Nov 11, 2023
Copy link
Contributor

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 11, 2023
@ulixius9 ulixius9 marked this pull request as ready for review November 11, 2023 03:06
harshach
harshach previously approved these changes Nov 11, 2023
Copy link

[open-metadata-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link

[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

27.5% 27.5% Coverage
0.0% 0.0% Duplication

@ulixius9 ulixius9 merged commit b34111e into main Nov 13, 2023
@ulixius9 ulixius9 deleted the es_connection_fix branch November 13, 2023 08:40
ulixius9 added a commit that referenced this pull request Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend documentation Improvements or additions to documentation Ingestion safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to ignore SSL certificate check for Elasticsearch connector
3 participants