Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): supported tooltip descriptions for domain types #13909

Merged
merged 3 commits into from
Nov 9, 2023

Conversation

Ashish8689
Copy link
Contributor

Describe your changes:

Fixes #13879

  • I worked on supported tooltip descriptions for domain types
image image

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Ashish8689 Ashish8689 added the UI UI specific issues label Nov 9, 2023
@Ashish8689 Ashish8689 self-assigned this Nov 9, 2023
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Nov 9, 2023
Copy link
Contributor

github-actions bot commented Nov 9, 2023

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 48%
48.89% (23454/47976) 30.76% (8802/28615) 30.42% (2673/8786)

@Ashish8689
Copy link
Contributor Author

@chirag-madlani updated the changes as per comments!

Copy link

sonarqubecloud bot commented Nov 9, 2023

[open-metadata-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Collaborator

@chirag-madlani chirag-madlani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harshach Can you review this as well?

@harshach harshach merged commit 14b9c48 into main Nov 9, 2023
@harshach harshach deleted the domain-type-tooltip branch November 9, 2023 14:46
Ashish8689 added a commit that referenced this pull request Nov 10, 2023
* supported tooltip description for domain types

* localization keys

* changes as per comments

(cherry picked from commit 14b9c48)
ulixius9 pushed a commit that referenced this pull request Nov 10, 2023
* supported tooltip description for domain types

* localization keys

* changes as per comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tooltips around Domain Type to explain Domains
3 participants