Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cypress): what's new pop-up alert box #13848

Merged
merged 2 commits into from
Nov 5, 2023

Conversation

Ashish8689
Copy link
Contributor

Describe your changes:

I worked on fixing what's new pop-up alert box

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Ashish8689 Ashish8689 added the UI UI specific issues label Nov 4, 2023
@Ashish8689 Ashish8689 self-assigned this Nov 4, 2023
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Nov 4, 2023
@Ashish8689 Ashish8689 marked this pull request as draft November 4, 2023 12:18
@Ashish8689 Ashish8689 marked this pull request as ready for review November 4, 2023 12:22
Copy link
Contributor

github-actions bot commented Nov 4, 2023

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 48%
49.01% (23430/47803) 30.83% (8793/28518) 30.49% (2673/8766)

Copy link

sonarqubecloud bot commented Nov 4, 2023

[open-metadata-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link

cypress bot commented Nov 4, 2023

7 failed tests on run #32143 ↗︎

7 430 63 0 Flakiness 0

Details:

remove manual timeout as not required such
Project: openmetadata Commit: 8703c056f0
Status: Failed Duration: 30:32 💡
Started: Nov 4, 2023 12:47 PM Ended: Nov 4, 2023 2:18 PM
Failed  Pages/SearchIndexDetails.spec.js • 3 failed tests • cypress-ci-mysql-oss-6754824129-1

View Output Video

Test Artifacts
SearchIndexDetails page should work properly for data consumer role > All permissible actions on search index details page should work properly Output Screenshots Video
SearchIndexDetails page should work properly for data steward role > All permissible actions on search index details page should work properly Output Screenshots Video
SearchIndexDetails page should work properly for admin role > All permissible actions on search index details page should work properly Output Screenshots Video
Failed  Service/MlFlow.spec.js • 2 failed tests • cypress-ci-mysql-oss-6754824129-1

View Output Video

Test Artifacts
ML Flow Ingestion > add and ingest data Output Screenshots Video
ML Flow Ingestion > Update MlModel description and verify description after re-run Output Screenshots Video
Failed  Service/postgres.spec.js • 1 failed test • cypress-ci-mysql-oss-6754824129-1

View Output Video

Test Artifacts
Postgres Ingestion > Verify if usage is ingested properly Output Screenshots Video
Failed  Service/superset.spec.js • 1 failed test • cypress-ci-mysql-oss-6754824129-1

View Output Video

Test Artifacts
Superset Ingestion > Update table description and verify description after re-run Output Screenshots Video

Review all test suite changes for PR #13848 ↗︎

@chirag-madlani chirag-madlani merged commit c5e7ff4 into main Nov 5, 2023
@chirag-madlani chirag-madlani deleted the whats-new-popup-cypress-fix branch November 5, 2023 05:19
Ashish8689 added a commit that referenced this pull request Nov 6, 2023
* fix(cypress): what's new popoup alert box

* remove manual timeout as not required such
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants