Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): domain styling color in the title if provided #13697

Merged
merged 3 commits into from
Oct 25, 2023
Merged

fix(ui): domain styling color in the title if provided #13697

merged 3 commits into from
Oct 25, 2023

Conversation

Ashish8689
Copy link
Contributor

@Ashish8689 Ashish8689 commented Oct 25, 2023 •
edited
Loading

Describe your changes:

  • fix domain styling color in the title if provided
  • UI spacing issue.
  • added autofocus in login and signup page
image image image image

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Ashish8689 Ashish8689 added the UI UI specific issues label Oct 25, 2023
@Ashish8689 Ashish8689 self-assigned this Oct 25, 2023
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Oct 25, 2023
chirag-madlani
chirag-madlani previously approved these changes Oct 25, 2023
View reviewed changes
@github-actions
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 48%
 48.59% (23206/47757) 30.36% (8587/28285) 30.12% (2642/8772)

@sonarqubecloud
Copy link

[open-metadata-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@chirag-madlani chirag-madlani merged commit c81c982 into main Oct 25, 2023
@chirag-madlani chirag-madlani deleted the domain-title-styling-fix branch October 25, 2023 17:02
akash-jain-10 pushed a commit that referenced this pull request Oct 26, 2023
@Ashish8689 @karanh37 @akash-jain-10
fix(ui): domain styling color in the title if provided (#13697)
352aaa0 
* supported domain styling color in title if provided

* fix on data product page

* fix: allow dot in mentions allowed char

---------

Co-authored-by: karanh37 <[email protected]>
@Ashish8689 Ashish8689 mentioned this pull request Oct 27, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@ShaileshParmar11 ShaileshParmar11 ShaileshParmar11 approved these changes

@harshach harshach Awaiting requested review from harshach

@karanh37 karanh37 Awaiting requested review from karanh37

Assignees

@Ashish8689 Ashish8689

Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ashish8689 @chirag-madlani @ShaileshParmar11 @karanh37