Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): change sidebar label to tooltip hover and supported multi language #12996

Merged
merged 4 commits into from
Aug 29, 2023

Conversation

Ashish8689
Copy link
Contributor

@Ashish8689 Ashish8689 commented Aug 24, 2023

Describe your changes:

  • change sidebar label to tooltip hover
  • supported multiple language for the sidebar label
image image image image

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 24, 2023

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 50%
50.75% (19916/39243) 29.17% (6993/23972) 31.49% (2263/7186)

@cypress
Copy link

cypress bot commented Aug 24, 2023

1 failed tests on run #28554 ↗︎

1 327 37 0 Flakiness 0

Details:

fix cpress issue
Project: openmetadata Commit: fc016271db
Status: Failed Duration: 31:12 💡
Started: Aug 25, 2023 11:48 AM Ended: Aug 25, 2023 12:19 PM
Failed  cypress/e2e/Features/RecentlyViewed.spec.js • 1 failed test • Tests with database mysql

View Output Video

Test Artifacts
Recently viwed data assets > recently view section should have at max list of 5 entity Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Copy link
Member

@aniketkatkar97 aniketkatkar97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment. Also alignment in the sub-menu here doesn't look good. Can you please take care of that as well?
Screenshot 2023-08-24 at 9 06 42 PM

@Ashish8689 Ashish8689 marked this pull request as draft August 24, 2023 15:43
@Ashish8689
Copy link
Contributor Author

@aniketkatkar97 @chirag-madlani updated the changes!

@Ashish8689 Ashish8689 temporarily deployed to test August 25, 2023 11:26 — with GitHub Actions Inactive
@Ashish8689 Ashish8689 temporarily deployed to test August 25, 2023 11:26 — with GitHub Actions Inactive
@sonarqubecloud
Copy link

[open-metadata-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.14.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@chirag-madlani
Copy link
Collaborator

@harshach Can you review this as well?

@chirag-madlani chirag-madlani merged commit 197dd19 into main Aug 29, 2023
@chirag-madlani chirag-madlani deleted the sidebar-tooltip branch August 29, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants