Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): sync date format with standard format #12986

Merged
merged 17 commits into from
Aug 28, 2023
Merged

fix(ui): sync date format with standard format #12986

merged 17 commits into from
Aug 28, 2023

Conversation

chirag-madlani
Copy link
Collaborator

@chirag-madlani chirag-madlani commented Aug 24, 2023

Describe your changes:

Fixes #8538

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 24, 2023

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 50%
51.15% (20171/39437) 29.63% (7133/24070) 32.11% (2317/7216)

@cypress
Copy link

cypress bot commented Aug 24, 2023

6 failed tests on run #28622 ↗︎

6 358 37 0 Flakiness 0

Details:

fix cypress
Project: openmetadata Commit: 16a4ea0a0e
Status: Failed Duration: 35:40 💡
Started: Aug 28, 2023 9:54 AM Ended: Aug 28, 2023 10:30 AM
Failed  postgres.spec.js • 1 failed test • Tests with database mysql

View Output Video

Test Artifacts
Postgres Ingestion > Verify if usage is ingested properly Output Screenshots Video
Failed  redshiftWithDBT.spec.js • 5 failed tests • Tests with database mysql

View Output Video

Test Artifacts
RedShift Ingestion > add and ingest data Output Screenshots Video
RedShift Ingestion > Update table description and verify description after re-run Output Screenshots Video
RedShift Ingestion > Add DBT ingestion Output Screenshots Video
RedShift Ingestion > Validate DBT is ingested properly Output Screenshots Video
RedShift Ingestion > delete created service Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@chirag-madlani chirag-madlani temporarily deployed to test August 28, 2023 09:30 — with GitHub Actions Inactive
@chirag-madlani chirag-madlani temporarily deployed to test August 28, 2023 09:30 — with GitHub Actions Inactive
@chirag-madlani chirag-madlani temporarily deployed to test August 28, 2023 09:30 — with GitHub Actions Inactive
@chirag-madlani chirag-madlani temporarily deployed to test August 28, 2023 09:30 — with GitHub Actions Inactive
@sonarqubecloud
Copy link

[open-metadata-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

0.0% 0.0% Coverage
5.7% 5.7% Duplication

warning The version of Java (11.0.14.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

Copy link
Contributor

@Sachin-chaurasiya Sachin-chaurasiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to have unit tests for date-time utils.

@chirag-madlani chirag-madlani merged commit ad21ae0 into main Aug 28, 2023
@chirag-madlani chirag-madlani deleted the fix-8538 branch August 28, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI : Use same date format across the application
3 participants