Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui):restrict whole page refresh on delete and restore in entity pages #12975

Merged
merged 11 commits into from
Aug 28, 2023

Conversation

Ashish8689
Copy link
Contributor

Describe your changes:

Fixes #10396

  • restrict whole page refresh on delete and restore in entity pages

Issue :

Screen.Recording.2023-08-23.at.5.08.35.PM.mov

Resolved :

Screen.Recording.2023-08-23.at.5.09.03.PM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 23, 2023

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 50%
51.1% (20203/39540) 29.55% (7132/24134) 31.89% (2316/7263)

@cypress
Copy link

cypress bot commented Aug 23, 2023

6 failed tests on run #28619 ↗︎

6 358 37 0 Flakiness 0

Details:

Merge branch 'main' into page-refresh
Project: openmetadata Commit: 705bf0434c
Status: Failed Duration: 29:04 💡
Started: Aug 28, 2023 9:52 AM Ended: Aug 28, 2023 10:21 AM
Failed  postgres.spec.js • 1 failed test • Tests with database postgresql

View Output Video

Test Artifacts
Postgres Ingestion > Verify if usage is ingested properly Output Screenshots Video
Failed  redshiftWithDBT.spec.js • 5 failed tests • Tests with database postgresql

View Output Video

Test Artifacts
RedShift Ingestion > add and ingest data Output Screenshots Video
RedShift Ingestion > Update table description and verify description after re-run Output Screenshots Video
RedShift Ingestion > Add DBT ingestion Output Screenshots Video
RedShift Ingestion > Validate DBT is ingested properly Output Screenshots Video
RedShift Ingestion > delete created service Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@Ashish8689 Ashish8689 temporarily deployed to test August 24, 2023 06:48 — with GitHub Actions Inactive
@Ashish8689 Ashish8689 temporarily deployed to test August 24, 2023 06:48 — with GitHub Actions Inactive
@Ashish8689 Ashish8689 temporarily deployed to test August 24, 2023 06:48 — with GitHub Actions Inactive
@chirag-madlani chirag-madlani temporarily deployed to test August 27, 2023 20:22 — with GitHub Actions Inactive
@chirag-madlani chirag-madlani temporarily deployed to test August 27, 2023 20:22 — with GitHub Actions Inactive
@sonarqubecloud
Copy link

[open-metadata-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.14.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@chirag-madlani chirag-madlani merged commit 93f7b83 into main Aug 28, 2023
@chirag-madlani chirag-madlani deleted the page-refresh branch August 28, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stay on same page when triggering ingestion pipeline
2 participants