Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ui): restrict unwanted api calls and fix some styling issue #12973

Merged
merged 7 commits into from
Aug 28, 2023
Merged

chore(ui): restrict unwanted api calls and fix some styling issue #12973

merged 7 commits into from
Aug 28, 2023

Conversation

Ashish8689
Copy link
Contributor

Describe your changes:

Fixes #10396

  • restrict unwanted API calls
  • fix some styling issue

Issue :
image

image
Screen.Recording.2023-08-23.at.2.18.59.PM.mov
Screen.Recording.2023-08-23.at.2.24.15.PM.mov
image

Resolved :

image image
Screen.Recording.2023-08-23.at.2.19.35.PM.mov
Screen.Recording.2023-08-23.at.2.23.43.PM.mov
image

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Ashish8689 Ashish8689 added the UI UI specific issues label Aug 23, 2023
@Ashish8689 Ashish8689 requested a review from harshach as a code owner August 23, 2023 08:57
@Ashish8689 Ashish8689 self-assigned this Aug 23, 2023
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Aug 23, 2023
@Ashish8689 Ashish8689 temporarily deployed to test August 23, 2023 09:31 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Aug 23, 2023 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 50%
 50.7% (19876/39203) 29.17% (6989/23963) 31.46% (2260/7183)

@Ashish8689 Ashish8689 temporarily deployed to test August 23, 2023 11:22 — with GitHub Actions Inactive
@cypress
Copy link

cypress bot commented Aug 23, 2023 •
edited
Loading

6 failed tests on run #28609 ↗︎

6 322 37 0 Flakiness 0

Details:

Merge branch 'main' into entity-api-optimization
Project: openmetadata Commit: f4344340b6
Status: Failed Duration: 32:26 💡
Started: Aug 28, 2023 6:33 AM Ended: Aug 28, 2023 7:06 AM
Failed  AddNewService/redshiftWithDBT.spec.js • 5 failed tests • Tests with database mysql

View Output Video

Test Artifacts
RedShift Ingestion > add and ingest data Output Screenshots Video
RedShift Ingestion > Update table description and verify description after re-run Output Screenshots Video
RedShift Ingestion > Add DBT ingestion Output Screenshots Video
RedShift Ingestion > Validate DBT is ingested properly Output Screenshots Video
RedShift Ingestion > delete created service Output Screenshots Video
Failed  Features/RecentlyViewed.spec.js • 1 failed test • Tests with database mysql

View Output Video

Test Artifacts
Recently viwed data assets > recently view section should have at max list of 5 entity Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@Ashish8689 Ashish8689 temporarily deployed to test August 23, 2023 13:14 — with GitHub Actions Inactive
@chirag-madlani chirag-madlani temporarily deployed to test August 25, 2023 15:27 — with GitHub Actions Inactive
@chirag-madlani chirag-madlani temporarily deployed to test August 25, 2023 15:27 — with GitHub Actions Inactive
@chirag-madlani chirag-madlani temporarily deployed to test August 26, 2023 07:02 — with GitHub Actions Inactive
@chirag-madlani chirag-madlani temporarily deployed to test August 26, 2023 08:57 — with GitHub Actions Inactive
@chirag-madlani chirag-madlani temporarily deployed to test August 26, 2023 08:57 — with GitHub Actions Inactive
@Ashish8689 Ashish8689 temporarily deployed to test August 28, 2023 03:57 — with GitHub Actions Inactive
@Ashish8689 Ashish8689 temporarily deployed to test August 28, 2023 03:57 — with GitHub Actions Inactive
@Ashish8689 Ashish8689 temporarily deployed to test August 28, 2023 03:57 — with GitHub Actions Inactive
@Ashish8689 Ashish8689 temporarily deployed to test August 28, 2023 03:57 — with GitHub Actions Inactive
@sonarqubecloud
Copy link

[open-metadata-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.14.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@Ashish8689 Ashish8689 temporarily deployed to test August 28, 2023 06:09 — with GitHub Actions Inactive
@chirag-madlani chirag-madlani merged commit 7683560 into main Aug 28, 2023
@chirag-madlani chirag-madlani deleted the entity-api-optimization branch August 28, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@harshach harshach Awaiting requested review from harshach

@karanh37 karanh37 Awaiting requested review from karanh37

Assignees

@Ashish8689 Ashish8689

Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stay on same page when triggering ingestion pipeline
2 participants
@Ashish8689 @chirag-madlani