Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 8930 - Update profiler timestamp from seconds to milliseconds #12948

Merged
merged 10 commits into from
Aug 25, 2023
Merged

Issue 8930 - Update profiler timestamp from seconds to milliseconds #12948

merged 10 commits into from
Aug 25, 2023

Conversation

TeddyCr
Copy link
Contributor

@TeddyCr TeddyCr commented Aug 21, 2023

Describe your changes:

Fixes #8930

Update timestamp for column and table from seconds to milliseconds

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.
  • I have added a test that covers the exact scenario we are fixing. For complex issues, comment the issue number in the test for future reference.

@TeddyCr TeddyCr requested a review from a team as a code owner August 21, 2023 12:23
@TeddyCr TeddyCr requested a review from a team August 21, 2023 12:23
@TeddyCr TeddyCr temporarily deployed to test August 21, 2023 12:23 — with GitHub Actions Inactive
@TeddyCr TeddyCr temporarily deployed to test August 21, 2023 12:23 — with GitHub Actions Inactive
@TeddyCr TeddyCr temporarily deployed to test August 21, 2023 12:23 — with GitHub Actions Inactive
@TeddyCr TeddyCr temporarily deployed to test August 21, 2023 12:23 — with GitHub Actions Inactive
@TeddyCr TeddyCr temporarily deployed to test August 21, 2023 12:23 — with GitHub Actions Inactive
@TeddyCr TeddyCr temporarily deployed to test August 21, 2023 12:23 — with GitHub Actions Inactive
@github-actions github-actions bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Aug 21, 2023
TeddyCr
TeddyCr commented Aug 21, 2023
View reviewed changes
bootstrap/sql/migrations/native/1.1.2/mysql/schemaChanges.sql
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We assume timestamps are in seconds as if it were ingested as milliseconds (would have happened through API call) the data would not have been displayed correctly.

@cypress
Copy link

cypress bot commented Aug 21, 2023 •
edited
Loading

2 failed tests on run #28525 ↗︎

2 326 37 0 Flakiness 0

Details:

fix: ran python linting
Project: openmetadata Commit: 4ce959c54a
Status: Failed Duration: 28:32 💡
Started: Aug 25, 2023 6:37 AM Ended: Aug 25, 2023 7:06 AM
Failed  AddNewService/postgres.spec.js • 1 failed test • Tests with database mysql

View Output Video

Test Artifacts
Postgres Ingestion > Verify if usage is ingested properly Output Screenshots Video
Failed  Features/RecentlyViewed.spec.js • 1 failed test • Tests with database mysql

View Output Video

Test Artifacts
Recently viwed data assets > recently view section should have at max list of 5 entity Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@ShaileshParmar11 ShaileshParmar11 temporarily deployed to test August 23, 2023 11:00 — with GitHub Actions Inactive
@TeddyCr TeddyCr temporarily deployed to test August 24, 2023 12:48 — with GitHub Actions Inactive
@TeddyCr TeddyCr temporarily deployed to test August 24, 2023 12:48 — with GitHub Actions Inactive
@sonarqubecloud
Copy link

[open-metadata-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.14.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@sonarqubecloud
Copy link

[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@TeddyCr TeddyCr temporarily deployed to test August 25, 2023 06:15 — with GitHub Actions Inactive
@TeddyCr TeddyCr merged commit 101cd0e into open-metadata:main Aug 25, 2023
TeddyCr added a commit that referenced this pull request Sep 6, 2023
@TeddyCr
Issue 8930 - Update profiler timestamp from seconds to milliseconds (#…
b9770de 
…12948)

(cherry picked from commit 101cd0e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@ulixius9 ulixius9 ulixius9 approved these changes

@harshach harshach Awaiting requested review from harshach

@karanh37 karanh37 Awaiting requested review from karanh37

Assignees
No one assigned
Labels
Ingestion profiler safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Test Case Result ts to milliseconds
4 participants
@TeddyCr @chirag-madlani @ulixius9 @ShaileshParmar11