Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #10344 - Use ingestionPipeline retries when deploying #12926

Merged
merged 8 commits into from
Aug 23, 2023

Conversation

pmbrull
Copy link
Collaborator

@pmbrull pmbrull commented Aug 18, 2023

Describe your changes:

Fixes #10344

When creating the ingestion, we should allow users to configure the number of retries if the workflow fails. By default, it will be 0.

We need to pass this information in the ingestionPipeline.airflowConfig.retries field. We have already updated the ingestion framework to use it.

We'll do the changes in the Collate repo accordingly

Screen.Recording.2023-08-21.at.5.54.05.PM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@pmbrull pmbrull temporarily deployed to test August 18, 2023 13:56 — with GitHub Actions Inactive
@pmbrull pmbrull temporarily deployed to test August 18, 2023 13:56 — with GitHub Actions Inactive
@pmbrull pmbrull temporarily deployed to test August 18, 2023 13:56 — with GitHub Actions Inactive
@pmbrull pmbrull temporarily deployed to test August 18, 2023 13:56 — with GitHub Actions Inactive
@pmbrull pmbrull temporarily deployed to test August 18, 2023 13:56 — with GitHub Actions Inactive
@github-actions github-actions bot added Ingestion safe to test Add this label to run secure Github workflows on PRs backend labels Aug 18, 2023
@pmbrull pmbrull requested a review from a team August 18, 2023 14:15
@cypress
Copy link

cypress bot commented Aug 18, 2023

Passing run #28269 ↗︎

0 321 37 3 Flakiness 0

Details:

Merge branch 'main' into issue-10344
Project: openmetadata Commit: 45572ad31e
Status: Passed Duration: 33:43 💡
Started: Aug 22, 2023 5:38 AM Ended: Aug 22, 2023 6:12 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@Sachin-chaurasiya Sachin-chaurasiya temporarily deployed to test August 21, 2023 08:22 — with GitHub Actions Inactive
@Sachin-chaurasiya Sachin-chaurasiya temporarily deployed to test August 21, 2023 08:22 — with GitHub Actions Inactive
@Sachin-chaurasiya Sachin-chaurasiya temporarily deployed to test August 21, 2023 08:22 — with GitHub Actions Inactive
@Sachin-chaurasiya Sachin-chaurasiya temporarily deployed to test August 21, 2023 08:22 — with GitHub Actions Inactive
@Sachin-chaurasiya Sachin-chaurasiya temporarily deployed to test August 21, 2023 08:22 — with GitHub Actions Inactive
@Sachin-chaurasiya Sachin-chaurasiya temporarily deployed to test August 22, 2023 05:16 — with GitHub Actions Inactive
@Sachin-chaurasiya Sachin-chaurasiya temporarily deployed to test August 22, 2023 05:16 — with GitHub Actions Inactive
@Sachin-chaurasiya Sachin-chaurasiya temporarily deployed to test August 22, 2023 05:16 — with GitHub Actions Inactive
@Sachin-chaurasiya Sachin-chaurasiya temporarily deployed to test August 22, 2023 05:16 — with GitHub Actions Inactive
@Sachin-chaurasiya Sachin-chaurasiya temporarily deployed to test August 22, 2023 05:16 — with GitHub Actions Inactive
@sonarqubecloud
Copy link

[open-metadata-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.14.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@sonarqubecloud
Copy link

[open-metadata-airflow-apis] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@pmbrull pmbrull changed the title [WIP] - Fix #10344 - Use ingestionPipeline retries when deploying Fix #10344 - Use ingestionPipeline retries when deploying Aug 23, 2023
@ayush-shah ayush-shah merged commit 4862b0d into open-metadata:main Aug 23, 2023
@pmbrull pmbrull deleted the issue-10344 branch August 23, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Ingestion safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Number of retries in Airflow is hard coded as zero
4 participants