Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions API #14786

Closed
harshach opened this issue Jan 19, 2024 · 0 comments · Fixed by #14821
Closed

Suggestions API #14786

harshach opened this issue Jan 19, 2024 · 0 comments · Fixed by #14821
Assignees
Labels

Comments

@harshach
Copy link
Collaborator

Feature
Suggestions API to add descriptions and tags/glossary terms as suggestions.

Describe the task
OpenMetadata provides various collaboration aspects to enable data teams to contribute the data asset documentations through "Requests for Description", "Request for tags" etc.. Although these are great enablers, we are looking to make this process simpler for anyone to edit the description as a suggestion to improve the docs around data assets.

/api/v1/suggestions

POST

 "id": {
      "description": "Unique identifier that identifies an entity instance.",
      "$ref": "../../type/basic.json#/definitions/uuid"
    },
  "suggestionType: {
      "enum": ["Description", "Tag", "GlossaryTerm"],
   },
 "entityLink": {
      "description": "Data asset about which this thread is created for with format <#E::{entities}::{entityName}::{field}::{fieldValue}.",
      "$ref": "../../type/basic.json#/definitions/entityLink"
    },
  "suggestedBy": {
     "$ref": "../../type/basic.json#/definitions/entityReference"
    },
   "description": {
       "$ref": "../../type/basic.json#/definitions/markdown"
     } ,
    "labels": {
      "description": "Tags or Glossary Terms.",
      "type": "array",
      "items": {
        "$ref": "../../type/tagLabel.json"
      },
      "default": null
    },

List

/api/v1/suggestions?fqn=entityFQN&suggestedBy='user/bot'&includeChildren=true

passing entityFQN will bring only entity related suggestions, if includeChildren is passed it will return all suggestions for columns as well

pass suggestedBy to bring specific user or bot suggestions

Apply

POST

/api/v1/suggestions/apply/{id}

pass specific instance suggestion, checks the logged in users permission for EDIT_ALL, EDIT_DESCRIPTION,EDIT_TAGS before applying

/api/v1/suggestions/apply/{fqn}

pass FQN to apply suggestions by specific user/bot and additional parameters to apply to children. This will help apply suggestions at bulk.

Reject

POST

/api/v1/suggestions/reject/{id}

/api/v1/suggestions/reject/{fqn}

harshach added a commit that referenced this issue Jan 23, 2024
@pmbrull pmbrull moved this to Backend - Bugs & Minor Features in Release 1.3.0 Jan 23, 2024
harshach added a commit that referenced this issue Feb 1, 2024
* Fix #14786: Suggestions API

* Handle suggestions in ometa

* Minor: Optimise Databricks Client (#14776)

* MINOR - Fix SP topology context & Looker usage context (#14816)

* MINOR - Fix SP topology context & Looker usage context

* MINOR - Fix SP topology context & Looker usage context

* Fix tests

* Fixes #14598: Fix Tags / Labels ingestion on includeTags as False (#14782)

* fix(ui): password error message for char limits (#14808)

* fix(ui): password error message for char limits

* fix java side code

* Fixes #13556: Support for Salesforce table description ingestion (#14733)

* ISSUE-13556: Add suport for Salesforce table description ingestion

* ISSUE-13556: Remove unnecessary blank line

* ISSUE-13556: Fix to get description for each table

---------

Co-authored-by: Teddy <[email protected]>

* MINOR - Better handling of Ingestion Pipeline Status (#14792)

* MINOR - Better handling of Ingestion Pipeline Status

* format

* format

* MINOR: Added table validation for cost analysis data (#14793)

* Added validation for cost analysis source

* centralized life cycle logic

* CYPRESS: simplify side navigation click in cypress (#14818)

* simplify side navigation click in cypress

* make sidbar item uses common enum

* fix cypress failure of outside import

* fix(#14326): tier dropdown is not working in advance search (#14780)

* improvement in advance search based on custom property

* fix a reading undefined property issue

* wip: advance search based on tier

* some code cleanup and improvement

* some fixes

* fix: ui flicker when advanceSearched is apply and refresh the page

* some cleanup

* no need to call customproperty api call, if entity not suppport customProperties

* minor change

* fix: autocomplete not working in tier search option in advance search modal

* added unit test for advance search provider component

* some cleanup

* added testcase for open modal

* added testcase for resetAllFilters method

* removed unwanted code

* added e2e test for testing tier advance search

* fix: e2e search flow for single field

* fix: string field not working after giving listValues in TierSearch

* fix: group query e2e test fix

* used asyncFetch way to get the tierOptions synchronously

* some cleanup

* remove unwanted lines

* some cleanup

* fix: selected option show option value instead of option title

* fix(minor): update skip icon for executions (#14809)

* Fixes #14803: ignore capitalization when confirming deletes  (#14804)

* ignore case when confirming deletes

* Test confirmation of deletes works when case differs 

Added test case for 'delete' as the confirmation text.

* minor(config): update openmetadata-ui code reviewers (#14823)

* Add Tests

* Add list/accept/reject apis

* initial ui changes

* localisation

* show suggestion for empty description

* ui feedbacks

* Fix permission check for entities without owner

* Fix entityLink and add tests

* Add update suggestion WIP

* Fix test

* Fix PUT and Pagination

* Fix styling

* update test

* Update status

* add OM server connection in apps

* add permissions check

* Fix CI

* Remove TODO

* Fix feedResourceTest

* fix unit tests

* add private configs for apps

* add private configs for apps

* fix update application icons

* minor center align icon

* add private configs for apps

* Format

* Fix pydantic gen

* Remove token

* Update name

* Rework private conf

* Fix apps

* Fix apps

* Format

* Format

* show metapilot only if its installed

---------

Co-authored-by: Pere Miquel Brull <[email protected]>
Co-authored-by: Mayur Singal <[email protected]>
Co-authored-by: Ayush Shah <[email protected]>
Co-authored-by: Chirag Madlani <[email protected]>
Co-authored-by: kwgdaig <[email protected]>
Co-authored-by: Teddy <[email protected]>
Co-authored-by: Onkar Ravgan <[email protected]>
Co-authored-by: Ashish Gupta <[email protected]>
Co-authored-by: Abhishek Porwal <[email protected]>
Co-authored-by: Carlo Q <[email protected]>
Co-authored-by: karanh37 <[email protected]>
@ulixius9 ulixius9 moved this from Backend - Bugs & Minor Features to Done in Release 1.3.0 Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants