Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Container: The breadcrumb is not getting updated #14560

Closed
ayush-shah opened this issue Jan 3, 2024 · 2 comments · Fixed by #14621
Closed

Container: The breadcrumb is not getting updated #14560

ayush-shah opened this issue Jan 3, 2024 · 2 comments · Fixed by #14621
Assignees
@Abhishek332
Labels
bug Something isn't working UI UI specific issues

Comments

@ayush-shah
Copy link
Member

The breadcrumb is not getting updated as we navigate through the hierarchy of container service.
@open-metadata/ui needs to check how we are sending values for creating breadcrumb

steps to reproduce:
Go back and forth different levels of hierarchy in containers and click on breadcrumbs to go back.
https://sandbox-beta.open-metadata.org/container/s3_storage_sample.deep_nested_container_1

Screen.Recording.2024-01-03.at.2.03.07.PM.mov
@ayush-shah ayush-shah added bug Something isn't working UI UI specific issues labels Jan 3, 2024
@Abhishek332
Copy link
Contributor

@chirag-madlani Can I get assign this issue

@Sachin-chaurasiya
Copy link
Contributor

@chirag-madlani Can I get assign this issue

Assiged to you @Abhishek332

@Abhishek332 Abhishek332 mentioned this issue Jan 8, 2024
Merged
@harshach harshach moved this to UI - Bugs & Minor Features in Release 1.3.0 Jan 9, 2024
chirag-madlani pushed a commit that referenced this issue Jan 16, 2024
@Abhishek332
Fix(#14560): fix breadcrumb not getting updating properly when clicki…
2414cfe 
…ng on any breadcrumb link in container page (#14621)

* reset the state of DataAssetHeaderComponent using key property when dataAsset get change to update the breadcrumb properly

* fix DataAssetHeader component getting render when contianerData is fetching in container page component

* wip: unit test for conitaner page

* added accidentally removed silent flag from jest test

* added test for check container data fetch with expected params

* added more testcase in ContainerPage unit test

* added switch tab testcase

* added more test case

* address comments

* address comments 1

* revert accidentally removed --silent from test command

* fix: unit test after conflict resolve

* fix page content shake on breadcrumb loading

* fix some type issues

* fix skeleton loading on detabase-schema-page

* fix LogsViewer Skeleton
@harshach harshach moved this from UI - Bugs & Minor Features to Done in Release 1.3.0 Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Abhishek332 Abhishek332

Labels
bug Something isn't working UI UI specific issues
Projects
No open projects
Release 1.3.0
Status: Done
Milestone
No milestone
4 participants
@chirag-madlani @ayush-shah @Sachin-chaurasiya @Abhishek332