Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CustomProperty page loading and error toast issue #14266

Closed
Ashish8689 opened this issue Dec 6, 2023 · 0 comments · Fixed by #14457
Closed

CustomProperty page loading and error toast issue #14266

Ashish8689 opened this issue Dec 6, 2023 · 0 comments · Fixed by #14457
Assignees
@chirag-madlani
Labels
UI UI specific issues

Comments

@Ashish8689
Copy link
Contributor

Affected module
Does it impact the UI, backend or Ingestion Framework?

Describe the bug

  • On update the property, button not showing any state of loading or disablity
  • On API error while update no toast message is shown

To Reproduce

Screen.Recording.2023-12-06.at.4.09.30.PM.mov
Screen.Recording.2023-12-06.at.4.18.09.PM.mov

Screenshots or steps to reproduce

Expected behavior
A clear and concise description of what you expected to happen.

Version:

  • OS: [e.g. iOS]
  • Python version:
  • OpenMetadata version: [e.g. 0.8]
  • OpenMetadata Ingestion package version: [e.g. openmetadata-ingestion[docker]==XYZ]

Additional context
Add any other context about the problem here.
@Ashish8689 Ashish8689 added the UI UI specific issues label Dec 6, 2023
@Ashish8689 Ashish8689 self-assigned this Dec 6, 2023
@harshach harshach moved this to UI - Bugs & Minor Features in Release 1.3.0 Dec 11, 2023
@harshach harshach removed this from Release 1.3.0 Dec 19, 2023
Sachin-chaurasiya added a commit that referenced this issue Dec 20, 2023
@Sachin-chaurasiya
Fix [#14266]: CustomProperty page loading and error toast issue
3d995e1
@Sachin-chaurasiya Sachin-chaurasiya mentioned this issue Dec 20, 2023
Merged
5 tasks
Sachin-chaurasiya added a commit that referenced this issue Dec 20, 2023
@Sachin-chaurasiya
Fix [#14266]: CustomProperty page loading and error toast issue (#14457)
4ebe343
Sachin-chaurasiya added a commit that referenced this issue Dec 20, 2023
@Sachin-chaurasiya
Fix [#14266]: CustomProperty page loading and error toast issue (#14457)
d174943 
(cherry picked from commit 4ebe343)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chirag-madlani chirag-madlani

Labels
UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix [#14266]: CustomProperty page loading and error toast issue open-metadata/OpenMetadata
2 participants
@chirag-madlani @Ashish8689