#14554 test case name's length limitation-DBT (#14815)

open-metadata · Jan 22, 2024 · 284ca34 · 284ca34
1 parent a9e1936
commit 284ca34
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 2 deletions.
diff --git a/openmetadata-ui/src/main/resources/ui/cypress/e2e/Pages/DataQualityAndProfiler.spec.js b/openmetadata-ui/src/main/resources/ui/cypress/e2e/Pages/DataQualityAndProfiler.spec.js
@@ -956,7 +956,7 @@ describe('Data Quality and Profiler should work properly', () => {
       .not('.ant-select-dropdown-hidden')
       .find(`[title="${profilerSetting.partitionIntervalType}"]`)
       .click();
-    cy.get('[data-testid="column-name"]').click();
+    cy.get('#includeColumnsProfiler_partitionColumnName').click();
     cy.get('.ant-select-dropdown')
       .not('.ant-select-dropdown-hidden')
       .find(`[title="${profilerSetting.partitionColumnName}"]`)

diff --git a/...ta-ui/src/main/resources/ui/src/components/AddDataQualityTest/components/TestCaseForm.tsx b/...ta-ui/src/main/resources/ui/src/components/AddDataQualityTest/components/TestCaseForm.tsx
@@ -305,6 +305,13 @@ const TestCaseForm: React.FC<TestCaseFormProps> = ({
             pattern: ENTITY_NAME_REGEX,
             message: t('message.entity-name-validation'),
           },
+          {
+            max: 256,
+            message: t('message.entity-maximum-size', {
+              entity: t('label.name'),
+              max: 256,
+            }),
+          },
           {
             validator: (_, value) => {
               if (testCases.some((test) => test.name === value)) {

diff --git a/...ta-ui/src/main/resources/ui/src/components/TableProfiler/Component/TableProfilerChart.tsx b/...ta-ui/src/main/resources/ui/src/components/TableProfiler/Component/TableProfilerChart.tsx
@@ -32,6 +32,7 @@ import { useHistory } from 'react-router-dom';
 import { ReactComponent as SettingIcon } from '../../../assets/svg/ic-settings-primery.svg';
 import { PAGE_HEADERS } from '../../../constants/PageHeaders.constant';
 import {
+  DEFAULT_RANGE_DATA,
   INITIAL_OPERATION_METRIC_VALUE,
   INITIAL_ROW_METRIC_VALUE,
 } from '../../../constants/profiler.constant';
@@ -79,7 +80,7 @@ const TableProfilerChart = ({
     onSettingButtonClick,
     isProfilingEnabled,
     customMetric: tableCustomMetric,
-    dateRangeObject,
+    dateRangeObject = DEFAULT_RANGE_DATA,
     onDateRangeChange,
   } = useTableProfiler();
 

diff --git a/...rces/ui/src/pages/IncidentManager/IncidentManagerDetailPage/IncidentManagerDetailPage.tsx b/...rces/ui/src/pages/IncidentManager/IncidentManagerDetailPage/IncidentManagerDetailPage.tsx
@@ -233,6 +233,7 @@ const IncidentManagerDetailPage = () => {
           </Col>
           <Col className="p-x-lg" data-testid="entity-page-header" span={24}>
             <EntityHeaderTitle
+              className="w-max-full-45"
               displayName={testCaseData.data?.displayName}
               icon={<TestCaseIcon className="h-9" />}
               name={testCaseData.data?.name ?? ''}