-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
minor: sanitize activity feed editor content (#16533)
- Loading branch information
1 parent
6af76c5
commit 14235c8
Showing
5 changed files
with
92 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 changes: 43 additions & 0 deletions
43
openmetadata-ui/src/main/resources/ui/src/utils/sanitize.utils.test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| /* | ||
| * Copyright 2024 Collate. | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| import { getSanitizeContent } from './sanitize.utils'; | ||
|
|
||
| describe('getSanitizeContent', () => { | ||
| it('should sanitize the input 1', () => { | ||
| const mockHtml = `<details/open/ontoggle=confirm('XSS')>`; | ||
| const result = getSanitizeContent(mockHtml); | ||
|
|
||
| expect(result).toBe(`<details open=""></details>`); | ||
| }); | ||
|
|
||
| it('should sanitize the input 2', () => { | ||
| const mockHtml = `<img src=x onerror=alert(1)//>`; | ||
| const result = getSanitizeContent(mockHtml); | ||
|
|
||
| expect(result).toBe(`<img src="x">`); | ||
| }); | ||
|
|
||
| it('should sanitize the input 3', () => { | ||
| const mockHtml = `<svg><g/onload=alert(2)//<p>`; | ||
| const result = getSanitizeContent(mockHtml); | ||
|
|
||
| expect(result).toBe(`<svg><g></g></svg>`); | ||
| }); | ||
|
|
||
| it('should sanitize the input 4', () => { | ||
| const mockHtml = `<p>abc<iframe//src=jAva	script:alert(3)>def</p>`; | ||
| const result = getSanitizeContent(mockHtml); | ||
|
|
||
| expect(result).toBe(`<p>abc</p>`); | ||
| }); | ||
| }); |
17 changes: 17 additions & 0 deletions
17
openmetadata-ui/src/main/resources/ui/src/utils/sanitize.utils.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| /* | ||
| * Copyright 2024 Collate. | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| import DOMPurify from 'dompurify'; | ||
|
|
||
| export const getSanitizeContent = (html: string): string => { | ||
| return DOMPurify.sanitize(html); | ||
| }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters