fix: OpenFeature::SDK::Configuration uses concurrent-ruby gem even though it doesn't depend on it #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am surprised our specs are passing as is, because we don't have a dependency on concurrent-ruby currently. I seemed to remember talking with @josecolella about this, and we decided to go with regular type Array for now. I was pretty sure we implemented that, but I guess not 🙃 Signed-off-by: Josh Nichols <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #61 +/- ##
=======================================
Coverage 98.90% 98.90%
=======================================
Files 6 6
Lines 91 91
=======================================
Hits 90 90
Misses 1 1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
technicalpickles
changed the title
josecolella
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
I am surprised our specs are passing as is, because we don't have a dependency on concurrent-ruby currently.
I seemed to remember talking with @josecolella about this, and we decided to go with regular type Array for now. I was pretty sure we implemented that, but I guess not 🙃
Related Issues
Notes
Follow-up Tasks
How to test