Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Flag Evaluation Requirement 1.1.4 and 1.1.5 and Provider Requirement 2.1.1 #112

Merged
merged 5 commits into from
Apr 2, 2024

Conversation

maxveldink
Copy link
Member

This PR

  • Adds pending requirement for Flag Evaluation 1.1.4 (will defer working on Hooks until we have Flag Evaluation, Provider and Evaluation Context implemented)
  • Adds tests for Flag Evaluation 1.1.5 and fixes a few configuration related issues that this uncovered
  • Adds tests for Provider Requirement 2.1.1 (already supported)

Follow-up Tasks

Will continue working on bringing other requirements over

@maxveldink maxveldink requested a review from a team as a code owner March 30, 2024 03:10
Copy link

codecov bot commented Mar 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.40%. Comparing base (3fe0123) to head (a6440c1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #112   +/-   ##
=======================================
  Coverage   99.40%   99.40%           
=======================================
  Files          12       12           
  Lines         167      168    +1     
=======================================
+ Hits          166      167    +1     
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Hooks will be implemented after the stabilized parts of the spec

Signed-off-by: Max VelDink <[email protected]>
@maxveldink maxveldink force-pushed the mv/requirement-1.1.4-and-1.1.5 branch from 32c49ca to dd39650 Compare March 30, 2024 03:11
@maxveldink maxveldink merged commit aac74b1 into main Apr 2, 2024
17 checks passed
@maxveldink maxveldink deleted the mv/requirement-1.1.4-and-1.1.5 branch April 2, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants