-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: drop Python 3.8 support #441
Conversation
Signed-off-by: gruebel <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #441 +/- ##
=======================================
Coverage 97.71% 97.71%
=======================================
Files 32 32
Lines 1621 1621
=======================================
Hits 1584 1584
Misses 37 37
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: gruebel <[email protected]>
@beeme1mr should we release it as 0.8 version or is 0.7.6 ok too? |
I'm fine with that and recommending keeping it a breaking change so we can it's very obvious in the release notes. I'm just wondering if we should release the async changes before merging this. |
Python 3.8 EOL was 2024-10-07. |
@beeme1mr yeah I thought about the same thing. I'm somehow more inclined to put the async change with this together into the first 0.8.0 version. It is technically not a breaking change, but still quite a big new feature. |
Sure, either way works for me. We should give folks a few days to let us know if dropping 3.8 is fine. Let's aim for merging this early next week unless we run into any blockers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
out with the old 😂
This PR
mypy
dropped 3.8 support in its latest version and the flagd test suite will benefit from it