Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Get Object should return both list and dict #64

Merged

Conversation

thomaspoignant
Copy link
Member

This PR

  • add the possibility for providers to return both dict and list while calling get_object_* functions.

Related Issues

Fixes #63

@thomaspoignant thomaspoignant changed the title Get Object should return both list and dict fix: Get Object should return both list and dict Dec 19, 2022
Signed-off-by: Thomas Poignant <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2022

Codecov Report

Merging #64 (83e4f9b) into main (4eee603) will decrease coverage by 0.23%.
The diff coverage is 92.30%.

@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
- Coverage   92.92%   92.69%   -0.24%     
==========================================
  Files          18       19       +1     
  Lines         325      342      +17     
==========================================
+ Hits          302      317      +15     
- Misses         23       25       +2     
Flag Coverage Δ
unittests 92.69% <92.30%> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
open_feature/provider/no_op_provider.py 100.00% <ø> (ø)
open_feature/provider/provider.py 75.00% <ø> (ø)
open_feature/immutable_dict/mapping_proxy_type.py 83.33% <83.33%> (ø)
open_feature/flag_evaluation/flag_type.py 100.00% <100.00%> (ø)
open_feature/open_feature_client.py 96.47% <100.00%> (+0.17%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@beeme1mr beeme1mr merged commit 85db1e0 into open-feature:main Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get_object should be able to return both dict and list
5 participants