Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_object should be able to return both dict and list #63

Closed
thomaspoignant opened this issue Dec 16, 2022 · 0 comments · Fixed by #64
Closed

get_object should be able to return both dict and list #63

thomaspoignant opened this issue Dec 16, 2022 · 0 comments · Fixed by #64

Comments

@thomaspoignant
Copy link
Member

thomaspoignant commented Dec 16, 2022 •
edited
Loading

The SDK is not able to return a list while calling get_object_*.
Other SDKs can return both list and dict with the get_object functions.

The AbstractProvider request to implement resolve_object_details and return a FlagEvaluationDetails[dict] object.
If we want to support both types we should return a FlagEvaluationDetails[Union[dict,list]] object.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Get Object should return both list and dict thomaspoignant/open-feature-python-sdk
1 participant
@thomaspoignant