Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(flagd): Context value hydration #195

Merged

Conversation

aepfli
Copy link
Member

@aepfli aepfli commented Feb 18, 2025

This pr adds context value hydration to the in-process evaluator.

This means, that flagd will provide contextual attributes on connection startup which will be used for inprocess evaluation, like defined in the spec.

https://flagd.dev/reference/specifications/providers/#sync-metadata-properties-in-the-evaluation-context

Follow-up:

  • make contextEnricher a config attribute

@aepfli aepfli requested a review from a team as a code owner February 18, 2025 17:30
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.28%. Comparing base (b0dac08) to head (1d46ae8).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #195      +/-   ##
==========================================
+ Coverage   94.13%   94.28%   +0.15%     
==========================================
  Files          17       18       +1     
  Lines         903      928      +25     
==========================================
+ Hits          850      875      +25     
  Misses         53       53              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aepfli aepfli force-pushed the feat/context-value-hydration branch from 596c22e to a5af90e Compare February 20, 2025 14:28
Copy link
Member

@toddbaert toddbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but consider the my comment.

@aepfli aepfli force-pushed the feat/context-value-hydration branch from 9431d23 to dceff15 Compare March 4, 2025 13:43
@aepfli aepfli force-pushed the feat/context-value-hydration branch from dceff15 to 6fef4af Compare March 5, 2025 11:51
Signed-off-by: Simon Schrottner <[email protected]>
@aepfli aepfli force-pushed the feat/context-value-hydration branch from 6fef4af to 1d46ae8 Compare March 5, 2025 13:24
@beeme1mr beeme1mr merged commit 4fa619b into open-feature:main Mar 5, 2025
22 checks passed
@chrfwow chrfwow deleted the feat/context-value-hydration branch March 6, 2025 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants