feat: make flags property mandatory for bulk evaluation success response #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kavindu Dodanduwa <[email protected]>
beeme1mr
approved these changes
Jun 25, 2024
lukas-reining
approved these changes
Jun 25, 2024
toddbaert
pushed a commit
to open-feature/flagd
that referenced
this pull request
Jun 27, 2024
This PR improves flagd bulk evaluation empty response by adding required `flags` property. Related - open-feature/protocol#27 Signed-off-by: Kavindu Dodanduwa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
bulkEvaluationSuccessright now only definesflagsproperty. This is the main property the response is expected to contain.Proposal
With this PR, I have made the
flagsproperty mandatory in the bulk evaluation response. This confirms to the current JavaScript implementation [1] whereflagsis required to make the response a valid one.[1] - https://github.com/open-feature/js-sdk-contrib/blob/ofrep-core-v0.1.5/libs/shared/ofrep-core/src/lib/model/bulk-evaluation.ts#L32-L38