chore: move client/ dir to web/ #991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Todd Baert <[email protected]>
toddbaert
force-pushed
the
chore/rename-client-dir-web
branch
from
7731fa7 to
4ccebd1
Compare
lukas-reining
approved these changes
Aug 27, 2024
beeme1mr
approved these changes
Aug 28, 2024
This was referenced Aug 28, 2024
toddbaert
added a commit
that referenced
this pull request
Aug 28, 2024
🤖 I have created a release *beep* *boop* --- ## [1.2.3](web-sdk-v1.2.2...web-sdk-v1.2.3) (2024-08-28) ### 🧹 Chore * **main:** release core 1.4.0 ([#984](#984)) ([01344b2](01344b2)) * move client/ dir to web/ ([#991](#991)) ([df4e72e](df4e72e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <[email protected]> Signed-off-by: Todd Baert <[email protected]> Co-authored-by: Todd Baert <[email protected]>
toddbaert
pushed a commit
that referenced
this pull request
Aug 28, 2024
🤖 I have created a release *beep* *boop* --- ## [0.4.4](react-sdk-v0.4.3...react-sdk-v0.4.4) (2024-08-28) ### 🧹 Chore * move client/ dir to web/ ([#991](#991)) ([df4e72e](df4e72e)) ### 📚 Documentation * **react:** update the error message ([#978](#978)) ([429c4ae](429c4ae)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been meaning to do this for a while... it just renames the
client/dir toweb/. I think this is better because there will be less confusion around the OpenFeature client object (which has it's own dirs) and because it's more consistent with the associated artifact name "web-sdk".