Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: extract and publish core package #629

Merged
merged 9 commits into from
Oct 31, 2023
Merged

feat: extract and publish core package #629

merged 9 commits into from
Oct 31, 2023

Conversation

toddbaert
Copy link
Member

@toddbaert toddbaert commented Oct 30, 2023 •
edited
Loading

This PR addresses: #616 by:

  • configuring CI to release a new module (in addition to server/web/react we now release the "core" module (previously called "shared").
  • adding a peer dep to the above module to server/web/react
  • adding a workflow to ensure that shared is released ahead of associated web/server/react changes, and which also auto-increments the peer dep version when the core module is released
  • unrelated typedoc improvements/updates

Note

I intend to create a new PR that will rename the dir structure according to the packages... so shared/ will become core/ and client/ will become web/. I just didn't want to add confusion and noise to this PR.

@toddbaert toddbaert requested a review from a team as a code owner October 30, 2023 20:10
@toddbaert toddbaert requested review from lukas-reining, beeme1mr, thomaspoignant and Kavindu-Dodan and removed request for a team October 30, 2023 20:10
@toddbaert toddbaert changed the title Feat/extract core release validation feat: extract and publish core package Oct 30, 2023
@open-feature open-feature deleted a comment from github-actions bot Oct 30, 2023
@toddbaert toddbaert force-pushed the feat/extract-core-release-validation branch from f2b9083 to 8e6db5b Compare October 30, 2023 20:12
@codecov
Copy link

codecov bot commented Oct 31, 2023 •
edited
Loading

Codecov Report

Merging #629 (5af6971) into main (4ce7606) will decrease coverage by 99.07%.
The diff coverage is n/a.

❗ Current head 5af6971 differs from pull request most recent head 19d18e3. Consider uploading reports for the commit 19d18e3 to get more accurate results

@@            Coverage Diff            @@
##             main   #629       +/-   ##
=========================================
- Coverage   99.06%      0   -99.07%     
=========================================
  Files          61      0       -61     
  Lines        2775      0     -2775     
  Branches      305      0      -305     
=========================================
- Hits         2749      0     -2749     
+ Misses         26      0       -26

see 61 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@toddbaert toddbaert force-pushed the feat/extract-core-release-validation branch from 5af6971 to 19d18e3 Compare October 31, 2023 14:14
@toddbaert
fixup: package lock
19d18e3 
Signed-off-by: Todd Baert <[email protected]>
@toddbaert toddbaert enabled auto-merge October 31, 2023 17:02
@toddbaert toddbaert added this pull request to the merge queue Oct 31, 2023
Merged via the queue into main with commit c3ee90b Oct 31, 2023
@toddbaert toddbaert deleted the feat/extract-core-release-validation branch October 31, 2023 17:03
This was referenced Oct 31, 2023
Merged
Merged
Merged
Merged
github-merge-queue bot pushed a commit that referenced this pull request Oct 31, 2023
@openfeaturebot
chore(main): release core 0.0.14 (#640)
cbcb009 
🤖 I have created a release *beep* *boop*
---


##
[0.0.14](core-v0.0.13...core-v0.0.14)
(2023-10-31)


### Features

* add support for clearing providers
([#578](#578))
([a3a907f](a3a907f))
* extract and publish core package
([#629](#629))
([c3ee90b](c3ee90b))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Signed-off-by: OpenFeature Bot <[email protected]>
Signed-off-by: openfeature-peer-update-bot <[email protected]>
Co-authored-by: openfeature-peer-update-bot <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Oct 31, 2023
@openfeaturebot
chore(main): release web-sdk 0.4.3 (#641)
696aaa7 
🤖 I have created a release *beep* *boop*
---


##
[0.4.3](web-sdk-v0.4.2...web-sdk-v0.4.3)
(2023-10-31)


### Features

* extract and publish core package
([#629](#629))
([c3ee90b](c3ee90b))


### Bug Fixes

* api docs links
([#645](#645))
([4ff3f0e](4ff3f0e))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Signed-off-by: OpenFeature Bot <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Oct 31, 2023
@openfeaturebot @toddbaert
chore(main): release server-sdk 1.7.0 (#636)
1b02a46 
🤖 I have created a release *beep* *boop*
---


##
[1.7.0](server-sdk-v1.6.3...server-sdk-v1.7.0)
(2023-10-31)


### Features

* add support for clearing providers
([#578](#578))
([a3a907f](a3a907f))
* extract and publish core package
([#629](#629))
([c3ee90b](c3ee90b))


### Bug Fixes

* api docs links
([#645](#645))
([4ff3f0e](4ff3f0e))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Signed-off-by: OpenFeature Bot <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
Co-authored-by: Todd Baert <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Oct 31, 2023
@openfeaturebot @toddbaert
chore(main): release react-sdk 0.0.2-experimental (#642)
aafe976 
🤖 I have created a release *beep* *boop*
---


##
[0.0.2-experimental](react-sdk-v0.0.1-experimental...react-sdk-v0.0.2-experimental)
(2023-10-31)


### Features

* extract and publish core package
([#629](#629))
([c3ee90b](c3ee90b))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Signed-off-by: OpenFeature Bot <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
Co-authored-by: Todd Baert <[email protected]>
This was referenced Mar 12, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weyert weyert weyert approved these changes

@beeme1mr beeme1mr beeme1mr approved these changes

@Kavindu-Dodan Kavindu-Dodan Kavindu-Dodan approved these changes

@thomaspoignant thomaspoignant thomaspoignant approved these changes

@lukas-reining lukas-reining lukas-reining approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@toddbaert @weyert @beeme1mr @Kavindu-Dodan @thomaspoignant @lukas-reining